Received: by 10.213.65.68 with SMTP id h4csp1692391imn; Thu, 15 Mar 2018 07:02:03 -0700 (PDT) X-Google-Smtp-Source: AG47ELtLI6ExY+pXnE4Q8csMI7ro6WUN56qbJDCCiTD/nivR8UurYoo8NrHHNidgCn2VO+6QYr4a X-Received: by 2002:a17:902:aa8d:: with SMTP id d13-v6mr8388763plr.378.1521122523537; Thu, 15 Mar 2018 07:02:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521122523; cv=none; d=google.com; s=arc-20160816; b=kcFX5hCCh40WXaLLdLslqBqvKbzEkFIUaXp2VLtBMcTc9egdnMkKhWUKpastylCd8d YcMzhZn9NAt6/CtbLhCE2+6ijujutXcDCFvWaMOYmUDKFjH9JiflSKDeg3h77v/Rn3cm JpAtZwDFvEcxmpUZRjnjbvfci/IC3OBQxjna0mtiVUAc6JjAcgLXuNC9dTj6jVoafLVM FDUpG//18fuaV+P76yXeXJIJKqsDriFYAXlGPAvyHB0N42MJng0ZiU0aZki7BDjL7jaO eWYenb6x/wJX2aHQCYdIvOeNpGENU6a/M+8jVIFxTw2LgZSxJuQ56UlMLI0NfUWVygXH e1LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=/Xwsl7HD3UMz3JZHNi8L+AiPI/rz8rJc3ZaCD7pJyyI=; b=IGaGHhBervc9UYv9JeZbCigWbz+Nt06WZsJncdOyghUvzHwI34IXr31lqRK9U3lXCB AN9wwRGXWIKGC+QsSymQWOwYueXu6unDrmNJJ0p+8nX4ooFUtUwRww7txrkG8wSV5xDa n3D/pDgIMw67NYwXlqTuAVkypEcjdglt+NQeDJrfkQQEAvzd+9LMEAE27ZkuFECHjAvV 2LgNU/IyynFYTfnnrpBzUl5aPrjHv2niX1pnMyk4ZrotVMsKfWqJGaUcVSx+h1naFRvp S1+MtLHkyKc5XouEk1Jc+uU6bd4F6axVlpLbBAs1VFcKYmUlCMt6/DS1jGeiej+hEKlC sf5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=XoKm1vsW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si3464059pgn.770.2018.03.15.07.01.32; Thu, 15 Mar 2018 07:02:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=XoKm1vsW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbeCON6k (ORCPT + 99 others); Thu, 15 Mar 2018 09:58:40 -0400 Received: from 8bytes.org ([81.169.241.247]:42688 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbeCON6j (ORCPT ); Thu, 15 Mar 2018 09:58:39 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id B572530C; Thu, 15 Mar 2018 14:58:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1521122318; bh=wbqx+NSeEA0LcgQVZQrj5X4K3FcZhqnTQFSJEy1W9KY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XoKm1vsWSknQKPIp7QVVTFJzHTt3sle8vuTYlkGTVOgNP0HqsdR3OpsFK4qKHg9Tg ztLPyGoHdRnGGlMewhhvxpQymDawfHJ6FG/cOpSn9TmnGm6navdAmRqPmVB9QQ5MWz 1Tsh+4SprGRF0lkifGsufKqtprodpNB3YAHN0qFhe69ieHMoHoxKDVZ/ERp//zFW1M NagWwfujuhnYU0lGkxEY8Yc8QhIjkfjnUW5ye9sT8h3CBzWULkH5iMu0ZO0Tw/XWBn tI+2XBoy3P3pP9Lf08fj9etIFFQzOeo8iEqB7RW66mEOA3g5HGU567cMcmKAhzrdtE 4SCKL9lfhEwyw== Date: Thu, 15 Mar 2018 14:58:38 +0100 From: Joerg Roedel To: Gary R Hook Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/5] Add debugfs info for the AMD IOMMU Message-ID: <20180315135838.GB5259@8bytes.org> References: <152106836233.67212.15861879210675477690.stgit@sosxen2.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152106836233.67212.15861879210675477690.stgit@sosxen2.amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 14, 2018 at 06:04:44PM -0500, Gary R Hook wrote: > Gary R Hook (5): > iommu/amd - Add debugfs support > iommu/amd - Add a 'verbose' switch for IOMMU debugfs > iommu/amd - Add a README variable for the IOMMU debugfs > iommu/amd - Expose the active IOMMU device table entries > iommu/amd - Add a debugfs entry to specify a IOMMU device table entry Same problem here as with the Intel patches, I don't think it's a good idea to reveal internal iommu data structures to user-space in this way. I've debugged iommu issues for around 10 years now and never had the need for an interface that reveals those internals. How exactly are you planning to use this information? Joerg