Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 15 Mar 2018 16:39:18 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <20180315163620.6122d752@bbrezillon>
References: <20180304200602.11475-1-stefan@agner.ch> <20180315163620.6122d752@bbrezillon>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2 1/2] mtd: rawnand: gpmi: add support for specific ECC strength
To:     Boris Brezillon <boris.brezillon@bootlin.com>, han.xu@nxp.com
CC:     boris.brezillon@free-electrons.com, max.oss.09@gmail.com,
        richard@nod.at, linux-kernel@vger.kernel.org,
        marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
        cyrille.pitchen@wedev4u.fr, dwmw2@infradead.org
From:   Stefan Agner <stefan@agner.ch>
Message-ID: <C8FA1701-52CE-46B6-9A3E-3249D1BDA4AC@agner.ch>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On March 15, 2018 4:36:20 PM GMT+01:00, Boris Brezillon <boris=2Ebrezillon=
@bootlin=2Ecom> wrote:
>Hi,
>
>On Sun,  4 Mar 2018 21:06:01 +0100
>Stefan Agner <stefan@agner=2Ech> wrote:
>
>> Add support for specified ECC strength/size using device tree
>> properties nand-ecc-strength/nand-ecc-step-size=2E
>
>Han, we didn't hear back from you on that=2E Are you okay with adding
>these new properties? IIRC, you feared there would be a delta between
>u-boot and linux support=2E
>
>Stephan, there's no changelog=2E Has anything changed in this version or
>is this just a RESEND?

Sorry forgot that=2E I just split documentation and driver changes=2E

--
Stefan

>
>Regards,
>
>Boris
>
>>=20
>> Signed-off-by: Stefan Agner <stefan@agner=2Ech>
>> ---
>>  drivers/mtd/nand/gpmi-nand/gpmi-nand=2Ec | 30
>++++++++++++++++++++----------
>>  1 file changed, 20 insertions(+), 10 deletions(-)
>>=20
>> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand=2Ec
>b/drivers/mtd/nand/gpmi-nand/gpmi-nand=2Ec
>> index 61fdd733492f=2E=2Ed04754289c03 100644
>> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand=2Ec
>> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand=2Ec
>> @@ -198,17 +198,16 @@ static inline bool gpmi_check_ecc(struct
>gpmi_nand_data *this)
>>   *
>>   * We may have available oob space in this case=2E
>>   */
>> -static int set_geometry_by_ecc_info(struct gpmi_nand_data *this)
>> +static int set_geometry_by_ecc_info(struct gpmi_nand_data *this,
>> +				    unsigned int ecc_strength,
>> +				    unsigned int ecc_step)
>>  {
>>  	struct bch_geometry *geo =3D &this->bch_geometry;
>>  	struct nand_chip *chip =3D &this->nand;
>>  	struct mtd_info *mtd =3D nand_to_mtd(chip);
>>  	unsigned int block_mark_bit_offset;
>> =20
>> -	if (!(chip->ecc_strength_ds > 0 && chip->ecc_step_ds > 0))
>> -		return -EINVAL;
>> -
>> -	switch (chip->ecc_step_ds) {
>> +	switch (ecc_step) {
>>  	case SZ_512:
>>  		geo->gf_len =3D 13;
>>  		break;
>> @@ -221,8 +220,8 @@ static int set_geometry_by_ecc_info(struct
>gpmi_nand_data *this)
>>  			chip->ecc_strength_ds, chip->ecc_step_ds);
>>  		return -EINVAL;
>>  	}
>> -	geo->ecc_chunk_size =3D chip->ecc_step_ds;
>> -	geo->ecc_strength =3D round_up(chip->ecc_strength_ds, 2);
>> +	geo->ecc_chunk_size =3D ecc_step;
>> +	geo->ecc_strength =3D round_up(ecc_strength, 2);
>>  	if (!gpmi_check_ecc(this))
>>  		return -EINVAL;
>> =20
>> @@ -230,7 +229,7 @@ static int set_geometry_by_ecc_info(struct
>gpmi_nand_data *this)
>>  	if (geo->ecc_chunk_size < mtd->oobsize) {
>>  		dev_err(this->dev,
>>  			"unsupported nand chip=2E ecc size: %d, oob size : %d\n",
>> -			chip->ecc_step_ds, mtd->oobsize);
>> +			ecc_step, mtd->oobsize);
>>  		return -EINVAL;
>>  	}
>> =20
>> @@ -423,9 +422,20 @@ static int legacy_set_geometry(struct
>gpmi_nand_data *this)
>> =20
>>  int common_nfc_set_geometry(struct gpmi_nand_data *this)
>>  {
>> +	struct nand_chip *chip =3D &this->nand;
>> +
>> +	if (chip->ecc=2Estrength > 0 && chip->ecc=2Esize > 0)
>> +		return set_geometry_by_ecc_info(this, chip->ecc=2Estrength,
>> +						chip->ecc=2Esize);
>> +
>>  	if ((of_property_read_bool(this->dev->of_node,
>"fsl,use-minimum-ecc"))
>> -				|| legacy_set_geometry(this))
>> -		return set_geometry_by_ecc_info(this);
>> +				|| legacy_set_geometry(this)) {
>> +		if (!(chip->ecc_strength_ds > 0 && chip->ecc_step_ds > 0))
>> +			return -EINVAL;
>> +
>> +		return set_geometry_by_ecc_info(this, chip->ecc_strength_ds,
>> +						chip->ecc_step_ds);
>> +	}
>> =20
>>  	return 0;
>>  }

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E