Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neil@brown.name>
To:     John Crispin <john@phrozen.org>
Date:   Fri, 16 Mar 2018 07:12:00 +1100
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1
In-Reply-To: <be0d1e2d-67c5-bac1-63d4-72568dbf9d23@phrozen.org>
References: <152105892255.22262.1902152685410223215.stgit@noble> <20180315104853.bthffdd4hzklzo6d@mwanda> <be0d1e2d-67c5-bac1-63d4-72568dbf9d23@phrozen.org>
Message-ID: <87muz9ayjz.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 15 2018, John Crispin wrote:

> On 15/03/18 11:48, Dan Carpenter wrote:
>> This all seems fine.  Generally the requirements for staging are that it
>> has a TODO, someone to work on it, and it doesn't break the build.  But
>> some of the patches don't have commit message and those are required and
>> some of the commit messages are just the changes you have made not don't
>> describe the actual code...
>>
>> John Crispin's email is john@phrozen.org.
>>
>> regards,
>> dan carpenter
>>
> Hi All,
>
> looks like i was CC'ed on the openwrt addr, which no longer exists. This=
=20
> series makes no sense. None of the stuff posted is anywhere near ready=20
> to be upstreamed.
>
> * we dont need a dedicated pinctrl driver, pinctrl-single will work fine=
=20
> on these SoCs
> * the DMA/sdhci driver is a hacked up version of the SDK driver.
> * drivers/net/ethernet/mediatek/* works on mt7623 and is easily portable=
=20
> to mt7621, same goes for the gsw driver.

Hi John,
 I think it makes sense in that, with the patches, the hardware works, and
 without the patches (at least the first) you cannot even build with
 CONFIG_SOC_MT7621=3Dy as pcibios_map_irq() is undefined.  Having
 working code is a great starting point for further development.
 It certainly isn't ready for upstream, which is why it is heading for
 drivers/staging.  This is explicitly for code that isn't yet ready.
 By putting the code there it should be safe from bit-rot, and can be
 worked on by multiple people.  It gets increased visibility so people
 can say how bad it is (as you have done - thanks).  This feed back is a
 valuable part of improving the code and getting it out of staging.

 I'll add notes to various TODO files based on your comments.  If you
 have anything else to add, it would be most welcome.  Thank you for
 making these patches available in the first place, so that my hardware
 can work!

Thanks,
NeilBrown

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlqq05AACgkQOeye3VZi
gbk5Iw/+NPdW6TS1ThKS/gXFj6owZBOnEcfDFU/vfLviOKra13dVetLwTnLLM1M3
Gh1GUN+hkPCnFXRbxVkrAd7OGOogJsOw1hFAx1MijiFpikW3P4vxM7XI1D9wUvr3
EUCtKW6HzwaKt6A52hbgP7oZj1uDUqTue3SG729Z9fP0kyBmUm2d1I4nfmnqRYeA
/VBjc9QhCY+jf6uVsbC/sUFUhQ8KEDrob7S8hitaysBzjjkyVFqZZv7ZTL5Zat5b
qI+33Dg85x4pLNj26M8M+cow5UW7DoKomklN/zDwpPQiDfrwv3M29KyQPXDFGyaz
JlpXHq5X+rSA5Efx9qlxtH4EzWZZmqX8W9Drg5VsqTac798DBIhErApsd4uQ71c1
OkrQ0vK83TdGXqpPcp9g+AZiFdLuX70QKPtQ2v8QOqrjgTwoOBhq7e5Yt73iSpkb
ANWlJdlp8pURdygFa6Oc3XwSGl91gBXn0w3zWAb2j7PQtBx0mI123mReivy/+yzL
KwWP6Fbxly/qiBxo02qTwuW1lHIZ5o+W0TX7/dcBcOlewOmnUr70Uvk/yJcNJfsO
nV5dceAjQetD1hJ1wjVEN6Vme4QbXa1IIv9Rf0+n/aGdL0NcP34ZhVAL9hXmchCw
/iDYsAli1bwXqP1738jlD6M0As8FTfI36pRh5z8fSmbNZc46R9U=
=kppU
-----END PGP SIGNATURE-----
--=-=-=--