Received: by 10.213.65.68 with SMTP id h4csp26398imn; Thu, 15 Mar 2018 15:25:56 -0700 (PDT) X-Google-Smtp-Source: AG47ELuhG6Kd5mZe4RvlJFFnnd1he3f9rgutF9lWBfKi0umhgLoKqsJXVbpIyl6sBFwQh3SRSfZO X-Received: by 2002:a17:902:8f8e:: with SMTP id z14-v6mr9690762plo.271.1521152756785; Thu, 15 Mar 2018 15:25:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521152756; cv=none; d=google.com; s=arc-20160816; b=VVX9OIBGcGi37fGZNE3ldTGSk5dZt7DZvfIYJXtCQpvpj5Vx02prlQLnHXyaCCfRXo wcaXADyTmvP9+Kquv+kFDtTe2k/EHvpvvyfnXYQ3T8DzTgtKh7J3e6SKCNNgV/Z5jOqI nVb/Y5khWbrvCP8Eo3aM9fM3UYWg9+Y7f8Fp7wF/a4y1vhAyYCax08dcFHezH3rKH2ur BB6qIxrYJMxQel/BT6WLOl9SAWux0PaziursUcBRaR0Jwz9rREmfYC/lwXsr9ftbMkFr UB3HQDP0z4LuTODYUQtoczX4fe8W+0g8UZ2Y1vEdPTQyv5a0CGHHztJAXDIJhTr9P9I1 HwsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ABp7gMqgyGPMHOcVWtSmp/WdB03SCs5hUHqigzbz0aY=; b=cIK7FHQnbkiD6QbYg+9Q+03v4Lnty4qb+bXk+gPxZY1ejT0MvaVTfpmg3LaH7ZKN5l DJLajsO0Qt7TSeR+Ty98kkTpPKZjSYou8u6QOFHyq+5Ccrsm7RIpYNWUMm5tbaWzoe4k QmC9dFsoRo40oc5nz+LWArk+xt1IcXi1IA2wJEScrJpeWewayVtMN33U+IQG5cA8VeDm GNLlodjRzw/OnnQh5KH+rYETWJecMnM7DVzy40ZnB3zI8gd1ND1V2UcJs4jSiPoFHKUu DSggbSFW60OjQHwRCwxhy3ePxKkh1K6Kb+GYyGNVZK6Q5YTdv4olmwXs4XN9sj4cjYmL CesQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=NdUzZU+1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t28si4494143pfk.187.2018.03.15.15.25.42; Thu, 15 Mar 2018 15:25:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=NdUzZU+1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932840AbeCOWX4 (ORCPT + 99 others); Thu, 15 Mar 2018 18:23:56 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:46019 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573AbeCOWXw (ORCPT ); Thu, 15 Mar 2018 18:23:52 -0400 Received: by mail-wr0-f196.google.com with SMTP id h2so9806891wre.12 for ; Thu, 15 Mar 2018 15:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ABp7gMqgyGPMHOcVWtSmp/WdB03SCs5hUHqigzbz0aY=; b=NdUzZU+1XR3YPcANu0QmVHXm3gG6TIJdR3zbx4Ocd2bSbKnrmLkq8LkHGIycG3uMmB 7m3M0GcyGNusRA0xA+jpSXzKPFdB0aNLOQNla/E/t1lGsrCnlO/nLOwhNFZ8BpriGVpW IWhmSNvhIdnTkc6MwY33fsgBVnJ40VFV9mQ5ZoYSsUow43Rkp8AlILeW9vDB3Ok/YVAV lI0FgFF0aRB+JFcXbTiLh+3GknofBlWg2b/Lm1jJ622/bvdWNEcjreXONfugIbghV4Wx WgyyVSPU2++0v2MCbIUp4OltUnXgtN4cQQ9k2t0OGMeBDA6m/mpcDTwrEegdi1JwhBnL Walw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ABp7gMqgyGPMHOcVWtSmp/WdB03SCs5hUHqigzbz0aY=; b=oXCVFGGqogD/+vW6+L+KqI0Ch/r6WfZzrScacNU64xuyPSwtOgsdLnF7rtGbXJOKja krTOvknFv8wjnEsOtvizHFpP8se1wvpPJrMZHIQ5x14QSwGMCYD+kuy4Vr3N2j/gyyiF Q3uaYRqO3WrahrsRP1s8IWzSBwAKuHrE/X6b/TM5IZh2OehVSqyePSIY96Awg26lapre rLx2JT5G+4aK6dLkBon3XnvkhZBBAgKEvDIZaH0DJRev/YgaEJhATs1sJONnkmScsNPK Uw0xpdmpvNyQ8lR0ZNtvUBTPSY73gTDeLq5vqRG02tesdFqLcPo5AkR0D7lmUEvKSWHt i8/Q== X-Gm-Message-State: AElRT7For2bec2ZSkusnFsCGZhcVpAi0IIZpBwHtXmPprN90v5XHd4er IKgn5QfC/KCRC//iF8n9PvuytA== X-Received: by 10.223.139.68 with SMTP id v4mr8900065wra.23.1521152631467; Thu, 15 Mar 2018 15:23:51 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id r136sm4005801wmf.18.2018.03.15.15.23.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 15:23:50 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1ewbHm-0007Bj-UM; Thu, 15 Mar 2018 16:23:46 -0600 Date: Thu, 15 Mar 2018 16:23:46 -0600 From: Jason Gunthorpe To: Sinan Kaya Cc: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Kalderon , Ariel Elior , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs Message-ID: <20180315222346.GC27537@ziepe.ca> References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> <1520997629-17361-3-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520997629-17361-3-git-send-email-okaya@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 11:20:24PM -0400, Sinan Kaya wrote: > Code includes wmb() followed by writel() in multiple places. writel() > already has a barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Since code already has an explicit barrier call, changing writel() to > writel_relaxed(). > > Signed-off-by: Sinan Kaya > Acked-by: Jason Gunthorpe > drivers/infiniband/hw/qedr/verbs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to RDMA for-next Thanks, Jason