Received: by 10.213.65.68 with SMTP id h4csp51386imn; Thu, 15 Mar 2018 16:27:30 -0700 (PDT) X-Google-Smtp-Source: AG47ELtoiA3VXo1hYp5dmWBMnKgp4IJfeB1W8Rbj/3Nw2sIVXPyJInH+yvEP3QEqhG2GOE/99JUN X-Received: by 10.98.231.26 with SMTP id s26mr9146503pfh.210.1521156450407; Thu, 15 Mar 2018 16:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521156450; cv=none; d=google.com; s=arc-20160816; b=GXSA8JQkkyWS30H++hILRPyuBiBgiFp0k7juvUgva1FR+NuXtoTG8/n6CZ++wrZeI/ /hVeEkX4Gq5Z4vHsu6dl9DQ52Hf8ho8KTDXReXvIfL2NnedOWYdy6VFj2aKZFWvDEbjY trKi9ne3em7J+G2a+tSIOJFpaj1SFFvu2VEanr9Ri3/O39ABLvOkm558/VVaH5Lvr4kH AGBfVUZXt1axej/ASwbU0rsTCK83ft3kePDZ/dXw9/RKV/NspSrkIAn3IdvH0NCUllCQ o2V3KgBQnqbhYeOOzjlhovcmPDIVroDAd+NVthHqspnpekQHPV4nV6FwtkZm9TirOmOT BOFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=0+sE0nOqoVqm5miti9vY4+65+m+ZuCbGm6qzvVEZP9Q=; b=gGiqps4GhfvYVg6k27RGtlORCd+bwiGFkhVoUOSsJzEspNZP5+YiyXgfeQOQCm+QSf PEj2ALMXhHkF18CfHFuplziDAmDov3W5502lmJROiu/SJ3wIzgZh/3XFlyRdvo56KCsJ H7du4pVT3qdNVX73RgQXlUrEIpUd+m+Nvbzt6v1pDu97Re6KTLt/40jdDuktDmmFZRcD WmO1ed1lC9VhrfI0bV1L9egMZNbnl74bOjk6QzGm5m4lEjW5GjnSFq/L+Nrtv+x1IjUv bZBPRj8gbE6H1wmsC9eBLFEoI1tC/OgXyEtnf1eDxE3LLwE2XB+oVPsDyZl42LimLF8h LCew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4si4594330pfg.265.2018.03.15.16.26.46; Thu, 15 Mar 2018 16:27:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933018AbeCOXXs (ORCPT + 99 others); Thu, 15 Mar 2018 19:23:48 -0400 Received: from mail.skyhub.de ([5.9.137.197]:40784 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932673AbeCOXXr (ORCPT ); Thu, 15 Mar 2018 19:23:47 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FqTQNAlSrlD9; Fri, 16 Mar 2018 00:23:30 +0100 (CET) Received: from pd.tnic (p200300EC2BC921000DB0D181F40EDD09.dip0.t-ipconnect.de [IPv6:2003:ec:2bc9:2100:db0:d181:f40e:dd09]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7417D1EC0283; Fri, 16 Mar 2018 00:23:30 +0100 (CET) Date: Fri, 16 Mar 2018 00:23:06 +0100 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/10] x86/microcode/AMD: Check microcode file sanity before loading it Message-ID: <20180315232306.GA31610@pd.tnic> References: <9964a6cf-00be-78ea-cc1e-7f7062716fce@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9964a6cf-00be-78ea-cc1e-7f7062716fce@maciej.szmigiero.name> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 12:07:34AM +0100, Maciej S. Szmigiero wrote: > Currently, it is very easy to make the AMD microcode update driver crash > or spin on a malformed microcode container file since it does very little > consistency checking on data loaded from such file. Ok, a couple of tips for the next time: * please send your reworked patchset for review after review of your current patchset has been completed. We normally send patchsets once a week. You've sent yours two days after and that's kinda too fast. I'm sure you can imagine reviewers have other work to do too. So please be patient before resending next time. If in doubt, the whole process is documented in Documentation/process/ - might wanna skim through it. * when sending your patchset, make sure all mails are sent as a reply to the 0/N message. Your 0/N has: Message-ID: <9964a6cf-00be-78ea-cc1e-7f7062716fce@maciej.szmigiero.name> but your 1/N has References: so something went wrong there. Normally git send-email does this correctly. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.