Received: by 10.213.65.68 with SMTP id h4csp53276imn; Thu, 15 Mar 2018 16:32:31 -0700 (PDT) X-Google-Smtp-Source: AG47ELuMOr5IYHQ44u9ocd3rxzZwPuSZGRVOwTWyVz5zmQm3yT/8Mnp/I/cSWRnR1mzKVL9nhYvG X-Received: by 10.99.112.92 with SMTP id a28mr7920388pgn.17.1521156751137; Thu, 15 Mar 2018 16:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521156751; cv=none; d=google.com; s=arc-20160816; b=iuuM3JI7XHvif543U3cRwUHexe1BX0J6PQ2Ez5gWkXQ5NzIovewpJPURCEzXOld8EP c+wei/0bMrqhasd7+ShoQqcOTh/33mnGJnFk4gqmtodsGdKfzYJUBc3O4grcrcWIOMkV JOTPl0YZFP52O9bd0+3ah8L7BKGANLRzzTJDyX9AghWyqBpCW7loJ1wgAkEhW87w62K5 5MPiPzLdutwHd9N3M8lee8dcKwzsCeneosVDPYCYCM9ffu61OXmHCKp/DlcDGM+LrVU/ f4+O7JIho0qfoFzqeLn7VqVo7Mfc2TmR092w98FDhPGlVHFZqyWphtdC1Y29/S02L7r1 Xadg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=IcWJOYdRc0Ii7Xgaok0mlJHryVtG5HC80EyOMkcOaPs=; b=qfq75Nd2UaT9AHmHdCXlwwocs5U4oEYS4uXNRKSBmRYX/IfMrFa2ius/cUzo1WOFWO gMKsbonbk3e1t9aDmVzxrMvqW0ez5K7oNZ5TD4snfa/Em93V2L8MwpIIzNTREE7/aLyB soFgg09VA/Z/6cv5sskXGR62bBLo6XQqWKO5ncFdoWc7oJ5lbv1SRL58CG7KsecGv0NE kAF4/pe7sqyygUR3cNlKc+xEgtruWpviVA70DNfVFK5M1CPu+yDT2vgtkKG4+AB0b/zl I5JU57yyrSjsyPclHqnzHvZNubcE5llSpmeuoSmj3DlD/hhBmyVNudLHlyqM+Blus9Hf 4lAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=goVrm9fX; dkim=pass header.i=@codeaurora.org header.s=default header.b=S0Lrrqzs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t6si1792800pfl.156.2018.03.15.16.32.16; Thu, 15 Mar 2018 16:32:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=goVrm9fX; dkim=pass header.i=@codeaurora.org header.s=default header.b=S0Lrrqzs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933095AbeCOXa5 (ORCPT + 99 others); Thu, 15 Mar 2018 19:30:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52424 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932841AbeCOXaz (ORCPT ); Thu, 15 Mar 2018 19:30:55 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1C16E60AF9; Thu, 15 Mar 2018 23:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521156655; bh=yLALobmbzha8r1RkFDWgJtII+ANYIgtTycJsQ0wA7H8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=goVrm9fXazlRGNssASTCoypnulqsplZquwEUkdIzODh5jwRJQP7Ubl5tS3adGFWub lWEAXmWHYAA6IZ9RukC65mEleNS5vQ0hHbCKUpyKr0WfXgQEzBij/lDeV3cI/7a6CR acQ4zDiA4SCO5vAoBuet4KXOM1kGNKpGmXBEXv0U= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.0.105] (cpe-174-109-247-98.nc.res.rr.com [174.109.247.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D198C6070A; Thu, 15 Mar 2018 23:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521156654; bh=yLALobmbzha8r1RkFDWgJtII+ANYIgtTycJsQ0wA7H8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=S0LrrqzsO0RnewIU/URp0yA7zqdgwXZ1jbxLSTl3g3uJ1Yi/Z6HHPDbaA7ww0a1SL mOV9RuiEI8LvaQmvdWHoGozBcsHKu+cS3fmwB/pbeKb3L/1PZWmR3JA/xC6ztpp0ua z8vWJZhs1BoIFxqA5XkV7Fh2AZGLHDMq55oLz6Qw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D198C6070A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 6/7] e1000: eliminate duplicate barriers on weakly-ordered archs To: Alexander Duyck Cc: Netdev , Timur Tabi , sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeff Kirsher , intel-wired-lan , LKML References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> <1520997629-17361-6-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: <39dc5bb4-02b1-bf7e-fbfc-17fc484e4fb7@codeaurora.org> Date: Thu, 15 Mar 2018 19:30:51 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/14/2018 9:41 PM, Alexander Duyck wrote: >> } >> > So you missed the writel in e1000_xmit_frame. You should probably get > that one too while you are doing these updates. The wmb() is in > e1000_tx_queue(). > I brought wmb() outside along with the next descriptor assignment to be similar to the rest of the other code. if wmb() and writel() are not visible in the same function, let's not touch the code. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.