Received: by 10.213.65.68 with SMTP id h4csp87995imn; Thu, 15 Mar 2018 18:06:30 -0700 (PDT) X-Google-Smtp-Source: AG47ELvDVGfrgDgYFJ2GrtwDinUA0iPzFKN6OGN04fVoelf9ahTLUglqPMo485LvwGKYoqHw0ERO X-Received: by 2002:a17:902:6bc1:: with SMTP id m1-v6mr5250949plt.303.1521162390597; Thu, 15 Mar 2018 18:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521162390; cv=none; d=google.com; s=arc-20160816; b=nHXZPcUF0UDBrliCkmxbXS51njR06FRweS+HtDXuOfNNxYD87FlCJRy6LXEbcweWbA Tp70CyBe6/A4zV5aodTkSDGATCkD98OgUZu6d2ssM+ilnrkYAYEJvLBZxH4UEZoYDitE x/VqMkwr1WpqcOmPhYPMk1L+MkcXk5N0XlnNVkrCqYeoPryUX65dMD+rDcsqYlREhJuH w0oYqzI1/2NVX3W2iIoapMAkAeOhWDi1oNJ10Y4ytQr5S+AHBRdz/5kRVlgj+dfKo2ah EmsKnT2qYV8Olu5XZ1JBzq9bbXTPWBrZrjIhywL6fbqdzvoW8nIzj5yv8atbXQi+IOAD Sovg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=dPIRzx7NCC9mMM+L/saPHZwJdA+ug/IHgcr04PUS400=; b=lSXU8ALDiLV/ZFHyaElHvtNcm28MMtcRhMI49IfIZskDMiKZLFQRcsJSqhU4JCMIxS AQqu74bidZoE9Eqeu7LAvf6Q03X0z7hPK9k4O690w6nbKp8NkWJGefN7PA2h98G1oiZo sT55c5F1eQ5iiYJuZwYMi1ivWyeQtXmm020l7mJiqEB4+xpPkl4sYY8gABvL8A64Gs09 O94jCbtMUWZPSlqU+2PNJesS7JVf8qIdVk7zqOihS6FDZ3wdjXEgzXI2PrNGXfcbaANx 5nwwnFawIeUPfJArILdGLBMYICynvKi9vPBDQTrxbeYqUp/xK26DRfJZs18U29naYXEL zYwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kYmx9hsT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c41-v6si4972166plj.150.2018.03.15.18.06.16; Thu, 15 Mar 2018 18:06:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kYmx9hsT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbeCPAZV (ORCPT + 99 others); Thu, 15 Mar 2018 20:25:21 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:47086 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802AbeCPAZT (ORCPT ); Thu, 15 Mar 2018 20:25:19 -0400 Received: by mail-wr0-f181.google.com with SMTP id m12so9979568wrm.13; Thu, 15 Mar 2018 17:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dPIRzx7NCC9mMM+L/saPHZwJdA+ug/IHgcr04PUS400=; b=kYmx9hsTfVvm1cw17j8Ok7tgfDeMZeYP/h+WpG8XjDXeZIZmRoG+UUtceTKuxhGZQe x0csjvx2LJX0tEsueYfrmitcBwnLeMqONV22+o4Az1mwHUeDWyxrh+zT2J3pynfhKwA2 GzfKTOklv9Mvi3CgoYqsgYCwFWTHqjOo+5zYrd5WlOz+3UHDB9t62WjqJnXvlLfKChgH 1SdfmCyWfsYbeQy9cphtwKmF1avKPTG0pE6G2hGylg+zblVztRcMg1xSo3Cm0Fhw+o6p beOgbk1yg5HVbUhr223IZkWhChy+lxwcXkiPaekY+yWMcuM62cKqt4YKzOYOC0F4ngib Pplw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dPIRzx7NCC9mMM+L/saPHZwJdA+ug/IHgcr04PUS400=; b=ErdecgYt+Td8EWAbTp/0Vk+UnG7HIZBhMCLXGO0nRLiyWswmo56M8IVrVodEbk+eAB 6JEfgMtVpSzQYySF0xZcrc2wEtZJ+b4XO8Ad+7Tyf/XBh2FQroZrMcOVoeVonjZ1vNA9 ep0uzp02Zadz7GObCzKpfMUa3P7MqOMpb0gSnz0b42uikn9Tg3YIcVSstZ8wVTfRdRwF qJZmBb7RFJ5HlLezxTZULU344eHHBpsa90GPGXSsQ+qm/W/z096mLeGXsHjYHDa0uBcT 72JoeVpDTcsmiVuZEdpOBqm9vCzdmwwkW44jKHvGo9aM4aThAgbXBvCEVyQwiwtK7vQx 484w== X-Gm-Message-State: AElRT7H5WLHL8Q7r/hUA/glhin7ad6tqaXZ7VBoo0flux5Cw26sZbfRd 72FfSrCXVGtbDYZ4mrgmtFEJ02CNlZwszkLJiiE= X-Received: by 10.223.192.76 with SMTP id c12mr8369708wrf.177.1521159918259; Thu, 15 Mar 2018 17:25:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.184.189 with HTTP; Thu, 15 Mar 2018 17:25:17 -0700 (PDT) In-Reply-To: <39dc5bb4-02b1-bf7e-fbfc-17fc484e4fb7@codeaurora.org> References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> <1520997629-17361-6-git-send-email-okaya@codeaurora.org> <39dc5bb4-02b1-bf7e-fbfc-17fc484e4fb7@codeaurora.org> From: Alexander Duyck Date: Thu, 15 Mar 2018 17:25:17 -0700 Message-ID: Subject: Re: [PATCH 6/7] e1000: eliminate duplicate barriers on weakly-ordered archs To: Sinan Kaya Cc: Netdev , Timur Tabi , sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeff Kirsher , intel-wired-lan , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 4:30 PM, Sinan Kaya wrote: > On 3/14/2018 9:41 PM, Alexander Duyck wrote: >>> } >>> >> So you missed the writel in e1000_xmit_frame. You should probably get >> that one too while you are doing these updates. The wmb() is in >> e1000_tx_queue(). >> > > I brought wmb() outside along with the next descriptor assignment to be > similar to the rest of the other code. > > if wmb() and writel() are not visible in the same function, let's not touch > the code. Maybe for e1000 we should just skip the driver entirely. Odds are you aren't going to have any e1000 parts running on ARM anyway since most of them are legacy PCI or PCI-X parts that were made over 10 years ago. Most of your efforts would probably be best spent on igb, igbvf, ixgbe, ixgbevf, i40e, i40evf, and fm10k.