Received: by 10.213.65.68 with SMTP id h4csp119728imn; Thu, 15 Mar 2018 19:37:25 -0700 (PDT) X-Google-Smtp-Source: AG47ELtUqvXKuAYM3C9qirlS47cfwy7MHs2AjNwLDnO285iFH21uHbkeEv1Zc6ipn/YDYVoKennx X-Received: by 10.99.112.77 with SMTP id a13mr112928pgn.253.1521167845530; Thu, 15 Mar 2018 19:37:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521167845; cv=none; d=google.com; s=arc-20160816; b=Pb8bi/6i0Kmdz29EJwpHBrGXRXhRbCYlMdYvv1axTY0RuPEf2bClnzKCah8D4g66Wt 2e+FM5yqQ2IZNi2xFa9LTMlHSQQNuiaN0Uy5zA4Z9juYgj4Py9r6QdQKD2F85bumZruD fYd02JqIr0vbuDidHc8w9iT5MqGE4bN0KyQ09t6j/31SsD5pW0DB5B72JvvxSstFPEa4 uiTxwDDrPWpO5D+UizIsuP7gbknkWV/+XonC5b7DM966Jfd0Eiz2JLysiHF5tzMIIuKk 0oUacNwThzx3GIYo1uJ+FHgwO9XOOioVDfyCHXVcZoAqb5fqq76e2wRbjcu2+FABCBfy JjCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=NUApXSLoMsV7FzoWD7T223Tyz4xUZQI/oCTAy1RMJww=; b=rl3yUzArNT87Por4PjBI3hX5kXw50QoQXSpGpw6UqqHH2S75QXl83mAfWoTu4xX7tw nr0Y1+gbM69PezcaLW9i08+Ad1DkDZzSQ0Dltr/6bF2/Lh+iW36G3W7kDYgj+f36mdvV xEGpzCUSEdMP8Y2GwZBlj2TGP2dBlOxFEfOyv42pdx8A+lOjAdH5DtVBNf8BUCmrMVVv d6YYoVlpsT29eFo4MFbhcaOu37MnlTDfKMQE4oJRIQaNDkxFbgsU/elpzo89ea2ZYW8Q qLbLLRCyYlddfKpiKyZ2iBTANZkrq9tgyNP1PaAwQRrYzjBjf1ktks1CDcmak8cfB4kd yzmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B8aSZsxu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l186si4322049pgd.174.2018.03.15.19.37.10; Thu, 15 Mar 2018 19:37:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B8aSZsxu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932706AbeCPCYf (ORCPT + 99 others); Thu, 15 Mar 2018 22:24:35 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:35679 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbeCPCYe (ORCPT ); Thu, 15 Mar 2018 22:24:34 -0400 Received: by mail-qt0-f194.google.com with SMTP id z14so9466768qti.2 for ; Thu, 15 Mar 2018 19:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=NUApXSLoMsV7FzoWD7T223Tyz4xUZQI/oCTAy1RMJww=; b=B8aSZsxu6LYiJwFK4+LiWolH/6qIv2mF5Vd5sT7plqk4X6HT/kR9TBz8Ft9niHWdTQ G0AnMbFKE0HBlIJO9pvNzwLo5e4jZJMQquJVHdHI0qTY5VDVLSxAMyAwjsCCRL6361a/ KWZ76wgk2Bh910js0OR/z8pmhcDEl7829xgHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=NUApXSLoMsV7FzoWD7T223Tyz4xUZQI/oCTAy1RMJww=; b=nfCIEj/JYCjfs9NVQ4awd+QraFH+SfUtvEPiD0dApa4+nDjIy0uSfVQF5xy2/qIpd+ uhUrnYM5kKSHirtLNJtuyKqwRJXk5nu1aFzMDiT8klcp8+ilCZgfOYd4pSJZUCVLyotd McPGYB9+EJRCSbn+5YnFRC4dTg00NKWkO+BRKJ+vkDTdd1IZSIC55aKK7qa/OXzkURwE EFWSsx+movp/7qeTF4qLHvbg7Bv2TzJLGNMx3IBq4oIYll6n6xeC2ZfaYvjlQE9th22O Rp7xtHvunQg0IOV4Ho054XCCrPiQq9N1DBbxBc6rbEZbp98DpfXwYtEhN1zZinTWumov hOIw== X-Gm-Message-State: AElRT7EDnbF40E0UOk/m6cJ+wcLppK4K1u2I5hVenzoMTfEuROi6VuSs mULq2OYjo0lzxRMgAw4D+Iql0w== X-Received: by 10.237.32.226 with SMTP id 89mr225342qtb.150.1521167073426; Thu, 15 Mar 2018 19:24:33 -0700 (PDT) Received: from xanadu.home (modemcable228.104-82-70.mc.videotron.ca. [70.82.104.228]) by smtp.gmail.com with ESMTPSA id t186sm4305803qkh.74.2018.03.15.19.24.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 19:24:32 -0700 (PDT) Date: Thu, 15 Mar 2018 22:24:32 -0400 (EDT) From: Nicolas Pitre To: Masahiro Yamada cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh In-Reply-To: <1521166725-24157-3-git-send-email-yamada.masahiro@socionext.com> Message-ID: References: <1521166725-24157-1-git-send-email-yamada.masahiro@socionext.com> <1521166725-24157-3-git-send-email-yamada.masahiro@socionext.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Mar 2018, Masahiro Yamada wrote: > The comment mentions it creates autoksyms.h in case it is missing, > but the actual code touches it when it does exists. > > The build system creates it anyway because and > need it. > > The code would not have worked as intended, and people have not > noticed it. This is a proof that we can simply remove it. > > Signed-off-by: Masahiro Yamada Acked-by: Nicolas Pitre > --- > > Changes in v2: > - Remove the code instead of fixing it > > scripts/adjust_autoksyms.sh | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh > index a162258..e0dd0d5 100755 > --- a/scripts/adjust_autoksyms.sh > +++ b/scripts/adjust_autoksyms.sh > @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in > . "./${KCONFIG_CONFIG}" > esac > > -# In case it doesn't exist yet... > -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi > - > # Generate a new ksym list file with symbols needed by the current > # set of modules. > cat > "$new_ksyms_file" << EOT > -- > 2.7.4 > >