Received: by 10.213.65.68 with SMTP id h4csp231899imn; Fri, 16 Mar 2018 01:00:33 -0700 (PDT) X-Google-Smtp-Source: AG47ELturuWjcKEe0XaTIHkikFbDYSijV6+yOdLeub6QGKgEMo9/OYzTiHD9qbwV2zJx8fJvbQ8H X-Received: by 2002:a17:902:a589:: with SMTP id az9-v6mr1041165plb.283.1521187233308; Fri, 16 Mar 2018 01:00:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521187233; cv=none; d=google.com; s=arc-20160816; b=nwB8NUQlnsFi4lMaE/NnOoNOGUxuGvwFVK6iMqU8xxVwGCyDFZR0t87r4NgO5Gh/we duQz4DQl4pfFu5fqhWgp36EXlCt2d8RzPDBeOC64T6LIphadBX4GzkrQnVPGLD2qVXRP I484g6rKmjXeuZlaVeJRxVP6+ImuyCN6pnIW1z1+vxsIKzwtzYxsUIp7nmRs+0HEYZ3q NsHJ+Z596BFxq2dXCBf/FEbotCBQcG+kMXSY0QVqUIE3m23E+cCsNAdaP35wLZRUE/yQ yQg9t5Fov1BSP0gtqDz5nQpI4FEcBCs93fXo95/FQfF0odKslRIngf2aR7U7nWBWW9Zn FvmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=KHgn3Q1bikHSOOytLBam05zdBg6mL99/QzZIPqz+SYI=; b=RbTIIxLRp3IqT+Y1c35bkBpjcj1OajfRlNguQbs/xUI+544XqZwceefeFryTxHonPk 6YeS/5mbvYujXov0VFJk3VmBeOefXKPRqYkzK4ZrMGvZYCZLszTlSQuMfIfy2Pw/Gg7h Ul9Bj3ctYIL2bnh9sL7Dqp42mrdNGYreyVnh+2SZN/OxQlyavEjlxZCLky8xLya9VT3k +qXuY2hguLhR4z36uisgccqKh/zV8TOiAM3kYyNg/xSsJEP9I9k0NoeIjNzGCRD/DtbR zEBkV6r2gUvE6PS8qs6Tf1lRNiy1FTfFLl/uWzTeBrTWG4kCd3yv48ZU6AARSIxS1aEq BjFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l63-v6si5678533plb.7.2018.03.16.01.00.19; Fri, 16 Mar 2018 01:00:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbeCPH7P (ORCPT + 99 others); Fri, 16 Mar 2018 03:59:15 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:54973 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbeCPH7P (ORCPT ); Fri, 16 Mar 2018 03:59:15 -0400 Received: from hsi-kbw-5-158-153-52.hsi19.kabel-badenwuerttemberg.de ([5.158.153.52] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ewkGf-000511-A8; Fri, 16 Mar 2018 08:59:13 +0100 Date: Fri, 16 Mar 2018 08:59:12 +0100 (CET) From: Thomas Gleixner To: Dou Liyang cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, mingo@elte.hu, peterz@infradead.org, jiangshanlai@gmail.com Subject: Re: [PATCH] kernel/cpu: Move cpuhp_is_atomic_state() into #ifdef CONFIG_SMP In-Reply-To: <20180316063852.22701-1-douly.fnst@cn.fujitsu.com> Message-ID: References: <20180316063852.22701-1-douly.fnst@cn.fujitsu.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Mar 2018, Dou Liyang wrote: > Commit 17a2f1ced028 ("cpu/hotplug: Merge cpuhp_bp_states and cpuhp_ap_states") > removed the last use of cpuhp_is_atomic_state() in common case, that caused > Kernel produced a warning: > > 'cpuhp_is_ap_state' defined but not used > > So, Move it into #ifdef CONFIG_SMP Thanks for the patch, but a fix is already queued in the smp/hotplug branch. It just did not make it into the for-next branch yet, Thanks, tglx