Received: by 10.213.65.68 with SMTP id h4csp253964imn; Fri, 16 Mar 2018 01:55:47 -0700 (PDT) X-Google-Smtp-Source: AG47ELtZXkzbqBRY0s+Yw7V1Q+kX9Xi+rLU1rq6eysc2MCYBsK3kcTbLmVz4XfXOz3Iauszq9gv9 X-Received: by 10.101.99.18 with SMTP id g18mr849291pgv.436.1521190547435; Fri, 16 Mar 2018 01:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521190547; cv=none; d=google.com; s=arc-20160816; b=avDlWuYNuBUw2Sin5b3eBORjuKcCjEh4n+nuuGjz6wXIEa2CfXlhxVr0qLdCL9pW8/ nrobiBK6syoY3H8ET0UUvUEZO6Lbm09eAyh7hut/jS6b1VrtYbsHbYPVOz8T3pNarq30 hFbjE9OFOdGTzGNX3nfZCZQL/qJ5xWZVp8+ktDImC485/L+yL22F7Wat3wt3bWg4DMUJ nrVrZ46k3J2qdkboIxkSUd6KaQQ/4eExI4r89/WTxKiFpEqZnDtituJiAQEI4Xwv21zI zNPK1eEB07IIJBUlyjU7aiIF+xQppbE4qPFImgAnQDItreWTvtiDwZ0PemDfPgcto9rC pu7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=mYIG2GLcGFW++ipTXCEU7BiaY46v1EJWu+yO2m9O92U=; b=RYPT8PHSGwzAmM5i2ooCQfSsg2YsaEvwA4AvnolUce19K5ZpY5o1bw2GqWvtsc9b+d Zn1/vKDXNqiw3qY2oc92y5/KDwGHIohEuPFMLIq5enompyumJDqhaLH97bljP6UOPKOq cy7R2LwMCjfVVwIzKvMf+Xrz9V/RlY5RceAeUzYEZhmR4/mKlGesmknZpKw2nqz2+dgC yPb0MbhUt/BF38pEGBK66D6j2w8F4P64AVN7fDNHPrgsv1iKLNZXECqCV0lj4Bg7etUl SeOJjoJq5DLVVsRbiIg9mNf1IYtZ8gtNiqBNGcsgrsQS27mFR3yx0pWCrlYlIFQW266E Ndtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Aft2Lv7O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w31-v6si5726104pla.315.2018.03.16.01.55.32; Fri, 16 Mar 2018 01:55:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Aft2Lv7O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753226AbeCPIy1 (ORCPT + 99 others); Fri, 16 Mar 2018 04:54:27 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:58348 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbeCPIy0 (ORCPT ); Fri, 16 Mar 2018 04:54:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mYIG2GLcGFW++ipTXCEU7BiaY46v1EJWu+yO2m9O92U=; b=Aft2Lv7OSAzarLdgcJo4fjJK+ ojRoC6juCRunQVeUv1Iy65NEgaZ2SOHJOik3qOhmGuYyHzCqtJAmlZJ1vYAySHVIFeqvh2Tpb6fDr +D9yKwhD0JxQbg/JCn/CzctgSAyda5NKypX9VVbVwJ5H6HLIDKKejXGMmyCk6Aytc/n4dIcOGvAP4 Esva7UgJfQtLwMgwqHa8BGq4TsGzob30RwuaOf8giP/FKYIqcW8HFALPvB85FG7ipl97RBB5zb9lm LqFloH9c3fWM11lN9a2MPYpw/v+hy7E31H8Sazjp0SLfA1bli7WTzbvVcZzFwdkN1RqhHz2/b46Nq NvjSTrL+Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewl83-00015s-J8; Fri, 16 Mar 2018 08:54:23 +0000 Date: Fri, 16 Mar 2018 01:54:23 -0700 From: Christoph Hellwig To: Linus Torvalds Cc: Andy Lutomirski , Arnd Bergmann , Dominik Brodowski , Linux Kernel Mailing List , Al Viro , Ingo Molnar , Andrew Morton Subject: Re: [PATCH v2 00/36] remove in-kernel syscall invocations (part 1) Message-ID: <20180316085423.GH4151@infradead.org> References: <20180315190529.20943-1-linux@dominikbrodowski.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 05:54:27PM -0700, Linus Torvalds wrote: > Yes. And honestly, I'd rather have these kinds of "just change the > calling convention" almost automated patches separately - and then the > cleanups later. > > Mixing the calling convention change and the cleanup together is just > confusing and potentially causes subtle issues. A lot of the issues here is that the initramfs / do_mount code is written as if it was user space code, but in kernel space. E.g. using file desriptors etc. I think doing one or a few patches before this series to sort this out would really reduce the scope of work and be the right thing. For any additional minor cleanups I agree that it might make sense to postpone them.