Received: by 10.213.65.68 with SMTP id h4csp256044imn; Fri, 16 Mar 2018 02:00:59 -0700 (PDT) X-Google-Smtp-Source: AG47ELu378k5+Et7LO/KAYtFtOCyXNeLUcZGB3BM6HZDuBbU7orLMLBPOKBP0amTJ9LimSM9Mkt8 X-Received: by 10.99.103.69 with SMTP id b66mr850723pgc.233.1521190859176; Fri, 16 Mar 2018 02:00:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521190859; cv=none; d=google.com; s=arc-20160816; b=IYMyXr/r157X0sbE1Ze6ll6HDY10v35XUe34Yl7r1s7gyaQu4LsQeJHD9fm5fReKB2 yr7Yjc3xWiT6QgGQCPwBG257KZ0S1EgC5BaOaX+hfXaMlPtr86qfd3g+akwaHHj+AUCC 46g3ixtwxGsTBDpOaV95Poo2DzDQmeq7QJAXY3IX9NVohuk7FwWd7Hu8DtUQg6Jl0/l2 6MAlwoPbu0B4sYmKDd/xG13BrYcfR+L6sKcc8ePwfAWXRzK83ZTBVW/aoKudFhfQgS2l /qAGJXc1gnWK+W7f0sCfjyeomP+fTXXI/hwEdjOdyupPwnDSEwY7oc2/JDuFfckMfSFe sM7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=yvQz998w4Xj3kW9iUe4EvAT6qWpbPTtDlN1OfNnhIpA=; b=wuyuDcJ1XrhQs4Dks51/fJFJyvhEhUZKGO3oDYHH8dqFmkViTUaqSa8TA64fhALm1h Mfl5l7o62y+t3wmxmlUDl0rWHdmpz/QVVfx6p9LQMCYKOqKUzrMcIsGeabr01YS4v3gq hj2/BWQsIBP8zvujftjbyWYbUIc7XyKZq8DxCi9I8uqEP3SMgjFGeD8SLO5msZ68kqw/ V3J6CVWJ10DQuz3XytJfkwsXN4NffRlNbmBO3Pmx42H20S8ZlNudSQzZrxobGdA5l8r7 FWSDJimUkyoNHmgGG1bDO4eVw0bLLL8TXb86YGmFWfjsfiN7vPzAL6Uf1jam5wQUeQUW 9PMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k8-v6si2431864pli.563.2018.03.16.02.00.44; Fri, 16 Mar 2018 02:00:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbeCPI7g (ORCPT + 99 others); Fri, 16 Mar 2018 04:59:36 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46714 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751724AbeCPI7e (ORCPT ); Fri, 16 Mar 2018 04:59:34 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2G8x0HT127538 for ; Fri, 16 Mar 2018 04:59:33 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2gr8j4d2w8-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Fri, 16 Mar 2018 04:59:33 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Mar 2018 08:59:31 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 16 Mar 2018 08:59:22 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2G8xM1q45088908; Fri, 16 Mar 2018 08:59:22 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BDF14A4040; Fri, 16 Mar 2018 08:52:09 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A502A4051; Fri, 16 Mar 2018 08:52:00 +0000 (GMT) Received: from [9.79.219.128] (unknown [9.79.219.128]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 16 Mar 2018 08:52:00 +0000 (GMT) Subject: Re: [PATCH 5/8] trace_uprobe: Support SDT markers having reference count (semaphore) To: Steven Rostedt Cc: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, srikar@linux.vnet.ibm.com, acme@kernel.org, ananth@linux.vnet.ibm.com, akpm@linux-foundation.org, alexander.shishkin@linux.intel.com, alexis.berlemont@gmail.com, corbet@lwn.net, dan.j.williams@intel.com, gregkh@linuxfoundation.org, huawei.libin@huawei.com, hughd@google.com, jack@suse.cz, jglisse@redhat.com, jolsa@redhat.com, kan.liang@intel.com, kirill.shutemov@linux.intel.com, kjlx@templeofstupid.com, kstewart@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, milian.wolff@kdab.com, mingo@redhat.com, namhyung@kernel.org, naveen.n.rao@linux.vnet.ibm.com, pc@us.ibm.com, pombredanne@nexb.com, tglx@linutronix.de, tmricht@linux.vnet.ibm.com, willy@infradead.org, yao.jin@linux.intel.com, fengguang.wu@intel.com, Ravi Bangoria References: <20180313125603.19819-1-ravi.bangoria@linux.vnet.ibm.com> <20180313125603.19819-6-ravi.bangoria@linux.vnet.ibm.com> <20180315124816.6aa3d4e2@vmware.local.home> From: Ravi Bangoria Date: Fri, 16 Mar 2018 14:31:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180315124816.6aa3d4e2@vmware.local.home> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18031608-0040-0000-0000-00000421D604 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031608-0041-0000-0000-00002624E218 Message-Id: <90b06fcf-e041-a0c0-d034-69f64d3eca36@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-16_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803160111 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2018 10:18 PM, Steven Rostedt wrote: > On Tue, 13 Mar 2018 18:26:00 +0530 > Ravi Bangoria wrote: > >> +static void sdt_increment_ref_ctr(struct trace_uprobe *tu) >> +{ >> + struct uprobe_map_info *info; >> + struct vm_area_struct *vma; >> + unsigned long vaddr; >> + >> + uprobe_start_dup_mmap(); > Please add a comment here that this function ups the mm ref count for > each info returned. Otherwise it's hard to know what that mmput() below > matches. Sure. Will add it. Thanks for the review, Ravi