Received: by 10.213.65.68 with SMTP id h4csp325407imn; Fri, 16 Mar 2018 04:26:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELtTKrYjqKeYvpRsEMcE4jwDS2vZF+Vaslm9Vyhfj2kuGtfTAck20Lqus34tSJVf1J6IZIl8 X-Received: by 2002:a17:902:aa8e:: with SMTP id d14-v6mr1751156plr.318.1521199584299; Fri, 16 Mar 2018 04:26:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521199584; cv=none; d=google.com; s=arc-20160816; b=S+qepizTjAEHZuk/6117nVcvRTzATkkRqpDWsBV43FeJPN7tbCBf5Qv1CbUAcJcS3/ 6AVF8GMiek02Ej+W3SaJRUM4g/ixYKlJqZmA3AplWpda4AqL9nUBt9ThSfarSYYh6fPN zEXPsWKB2lG/Ix+imxkhOWEO9rXFtO+e/jniOMIjyuHOPih5Z+Q7Vyh8bPghuw/yoRLS BN4UiApIZp72fk2ElfpokFjf+/r3KV/2e56gKXH/MvDcSwRzrSV+PAG5zvuTAXd8hHit QsHdoohJ68ptDY+pEWT9FcpVmyiBFHbXzSaxRPrJEzBihO8++q71Jfpltnvm2N0jT8IR ut1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=3q6IEJ0ebeLypMdg+E7r6yhuJ5AM7/IgNGOcVswqOcE=; b=sW7LFN63Wj6GWMLElXpHMaOjfeCw+0Q5kyoxZ7foW/0YJ2sPNSDg/kXGu96mnApWJM S7uUII5K3yR1EjoJVI9m/oqf2qRbJIr/h5Dw2ZmK975k4+yZsZnT8z1x6d2sd07Q1Guc losJayB8+QOOVSUxH1ujKKoP44FnrKkz4VXsAIfVHZ+A2Njc45bzRMYf85e5puNmIxEa 2DatDCp+rKepiYOzaBuybkgLe9YrERhW+YXpYfZdwmDlHkPUbGDm+1kdmvU+224y9C6o lS7/0UjoVmjl92jZXZEBMN6fLiI82i6yqzvBvmMhueK/CVjzJC7PdgkGnDinGtVxy8EL TPPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12-v6si6184955plk.615.2018.03.16.04.26.09; Fri, 16 Mar 2018 04:26:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbeCPLZM (ORCPT + 99 others); Fri, 16 Mar 2018 07:25:12 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:57204 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbeCPLZK (ORCPT ); Fri, 16 Mar 2018 07:25:10 -0400 X-Greylist: delayed 905 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Mar 2018 07:25:10 EDT Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2) (envelope-from ) id 1ewnFM-0000Io-9e; Fri, 16 Mar 2018 12:10:04 +0100 Received: from laforge by localhost.localdomain with local (Exim 4.90_1) (envelope-from ) id 1ewnER-0004fh-RC; Fri, 16 Mar 2018 12:09:07 +0100 Date: Fri, 16 Mar 2018 12:09:07 +0100 From: Harald Welte To: Kenneth Chan Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch Message-ID: <20180316110907.GK3523@nataraja> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kenneth, thanks for your fix. I'm not currently using any Panasonic Laptop devices anymore (After the CF-R series was discontinued), so I'm not able to properly maintain this driver anymore. However, your changes look sound to me (aside from that we don't use C++ style comments in kernel source code), hence: Acked-by: Harald Welte -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)