Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <aa838cdd-6333-68fc-0ead-8ad9e7fd8ff9@gmail.com>
References: <1521191569-21221-1-git-send-email-leechu729@gmail.com>
 <20180316125811.GB22994@kroah.com> <aa838cdd-6333-68fc-0ead-8ad9e7fd8ff9@gmail.com>
From:   =?UTF-8?B?5p2O5pu45biG?= <leechu729@gmail.com>
Date:   Fri, 16 Mar 2018 21:39:45 +0800
Message-ID: <CAFaeLdRkjy+fsYny4kXjsq2qOZqL9o8iqPn7hPP5wbeTrEHypw@mail.gmail.com>
Subject: Re: [PATCH] staging: typec: rt1711h typec chip driver
To:     Mats Karrman <mats.dev.list@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        heikki.krogerus@linux.intel.com,
        Guenter Roeck <linux@roeck-us.net>,
        =?UTF-8?B?c2h1ZmFuX2xlZSjmnY7mm7jluIYp?= <shufan_lee@richtek.com>,
        =?UTF-8?B?Y3lfaHVhbmco6buD5ZWf5Y6fKQ==?= <cy_huang@richtek.com>,
        Jun Li <jun.li@nxp.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

2018-03-16 21:29 GMT+08:00 Mats Karrman <mats.dev.list@gmail.com>:
> Hi,
>
> On 2018-03-16 13:58, Greg KH wrote:
>
>> On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote:
>>>
>>> From: ShuFan Lee <shufan_lee@richtek.com>
>>>
>>> Richtek RT1711H Type-C chip driver that works with
>>> Type-C Port Controller Manager to provide USB PD and
>>> USB Type-C functionalities.
>>> Add definition of TCPC_CC_STATUS_TOGGLING.
>>>
>>> Signed-off-by: ShuFan Lee <shufan_lee@richtek.com>
>>> ---
>>>   drivers/staging/typec/Kconfig         |   8 +
>>>   drivers/staging/typec/Makefile        |   1 +
>>>   drivers/staging/typec/tcpci.h         |   1 +
>>>   drivers/staging/typec/tcpci_rt1711h.c | 344
>>> ++++++++++++++++++++++++++++++++++
>>>   4 files changed, 354 insertions(+)
>>>   create mode 100644 drivers/staging/typec/tcpci_rt1711h.c
>>
>> This looks nice and simple to me, any reason it has to live in
>> drivers/staging/ and we can't just move it to drivers/usb/typec/ now?
>>
>> Or are there still api things that need to be resolved with the existing
>> drivers/staging/typec/ code?
>
>
> For one thing it depends on the tcpci driver that is still in staging unt=
il
> Jun Li's patches, [1], comes through.
>
> // Mats
>
> [1] https://marc.info/?l=3Dlinux-usb&m=3D152093458605648&w=3D2
>
>> thanks,
>>
>> greg k-h
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

Just like Mats said. Because tcpci_rt1711h.c depends on tcpci driver.
I'm not sure if I can put it to drivers/usb/typec/. So, I put it
staging first and move out after Jun's patches.

--=20
Best Regards,
=E6=9B=B8=E5=B8=86