Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] xen/acpi: upload _PSD info for non Dom0 CPUs too
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        linux-kernel@vger.kernel.org
Cc:     Juergen Gross <jgross@suse.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Erik Schmauss <erik.schmauss@intel.com>,
        xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
        devel@acpica.org
References: <20180315142205.15839-1-joao.m.martins@oracle.com>
 <bbf536dc-3c3d-8a25-47e8-7fd52850835d@oracle.com>
From:   Joao Martins <joao.m.martins@oracle.com>
Message-ID: <d14d48ab-9ba1-c70c-4d46-cd9c7c862add@oracle.com>
Date:   Fri, 16 Mar 2018 13:57:13 +0000
MIME-Version: 1.0
In-Reply-To: <bbf536dc-3c3d-8a25-47e8-7fd52850835d@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/15/2018 03:45 PM, Boris Ostrovsky wrote:
> On 03/15/2018 10:22 AM, Joao Martins wrote:
>> All uploaded PM data from non-dom0 CPUs takes the info from vCPU 0 and
>> changing only the acpi_id. For processors which P-state coordination type
>> is HW_ALL (0xFD) it is OK to upload bogus P-state dependency information
>> (_PSD), because Xen will ignore any cpufreq domains created for past CPUs.
>>
>> Albeit for platforms which expose coordination types as SW_ANY or SW_ALL,
>> this will have some unintended side effects. Effectively, it will look at
>> the P-state domain existence and *if it already exists* it will skip the
>> acpi-cpufreq initialization and thus inherit the policy from the first CPU
>> in the cpufreq domain. This will finally lead to the original cpu not
>> changing target freq to P0 other than the first in the domain. Which will
>> make turbo boost not getting enabled (e.g. for 'performance' governor) for
>> all cpus.
>>
>> This patch fixes that, by also evaluating _PSD when we enumerate all ACPI
>> processors and thus always uploading the correct info to Xen. We export
>> acpi_processor_get_psd() for that this purpose, but change signature
>> to not assume an existent of acpi_processor given that ACPI isn't creating
>> an acpi_processor for non-dom0 CPUs.
>>
>> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
Thanks!

I suppose what's remaining is review (or ack) from ACPI folks on the interface
changes made to acpi_processor_get_psd().

	Joao