Received: by 10.213.65.68 with SMTP id h4csp414623imn; Fri, 16 Mar 2018 07:06:58 -0700 (PDT) X-Google-Smtp-Source: AG47ELtNweCQC9DNvhg+cLBnAe47GQ9IdsTMk2biSgq+EIIxtX+0tsIY0mqA6bA1TuWZC7hfN5Hs X-Received: by 10.101.93.73 with SMTP id e9mr1612752pgt.264.1521209218914; Fri, 16 Mar 2018 07:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521209218; cv=none; d=google.com; s=arc-20160816; b=hR5znM5O6iwpxhsfGx7rZfsq0Tl+sKo6LIEn5PDXCXrSWrFZaGukaOuAQpKzbaoBJr bjvIbMOIhK097vtWOdop8+TFwVI18JO4LSKU0rWBRcCjEudEXgQpG2tcdhu30dsMDkTb znwqqRCBdTRAPweNJVuFxqfY8nksIpIR1Jn1AHO28EqGH/FCou8TATMY8KOxX2iPH9tm GSPYX8QB53RqGGQjA8NQpAMEKw2IP6qQvRuY8rAUz6g28qLXbtR48i4fc76QL+QuvDeI 8dG0+IuDnGimP2ho5DVvPwgmGHdB+RpUJbmVPN9ydqEWblyvNy+O+HZK5qdMng31TKSb aOEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=yQ5KCCv2/IgFLYf7ZcJL2Dr+b89eXf7lr2q3G6bRfLI=; b=o8TAtlZDgBnm2svIvWvliFylQuj+XWDyJ1viil7n4AYzsWyHSjdrA6m2YvUEgIozYX HypX4N5vU4BSyBQpthcVPkmG/dc7ipVGxavjr1VGND7NVZISdzAP8RSdKGEOlVpblmDu cijOpn0hDSwL718neV5W59DkDP6rPAvrKGZAamRbXd/kTOYojFYuYKNRd4Ag/+kTyXzi B6sFAhc/UXRaXvlUavvMhQ4+IXI1xw8dcLbmSUzOVJ6a6AB7wS5awBxOqe3rWsRZgjwv 5hbjNmc5OEucnM8JYqeZ0uJ9SR+RxWMODfhqaOq3NTGxgN7LW808UcIel7E0m+exex6U p4Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m37-v6si6393030pla.346.2018.03.16.07.06.28; Fri, 16 Mar 2018 07:06:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752878AbeCPOEG (ORCPT + 99 others); Fri, 16 Mar 2018 10:04:06 -0400 Received: from hermes.aosc.io ([199.195.250.187]:44051 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbeCPOEF (ORCPT ); Fri, 16 Mar 2018 10:04:05 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id C647D59788; Fri, 16 Mar 2018 14:04:00 +0000 (UTC) From: Icenowy Zheng To: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com, Icenowy Zheng Subject: [PATCH v4 3/9] pinctrl: sunxi: change irq_bank_base to irq_bank_map Date: Fri, 16 Mar 2018 22:02:09 +0800 Message-Id: <20180316140215.28663-4-icenowy@aosc.io> In-Reply-To: <20180316140215.28663-1-icenowy@aosc.io> References: <20180316140215.28663-1-icenowy@aosc.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Allwinner H6 SoC have its pin controllers with the first IRQ-capable GPIO bank at IRQ bank 1 and the second bank at IRQ bank 5. Change the current code that uses IRQ bank base to a IRQ bank map, in order to support the case that holes exist among IRQ banks. Signed-off-by: Icenowy Zheng --- Extracted in v4. drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c | 4 +++- drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 4 +++- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 7 +++++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c index da387211a75e..f043afa1aac5 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c @@ -481,11 +481,13 @@ static const struct sunxi_desc_pin sun8i_a33_pins[] = { SUNXI_FUNCTION(0x3, "uart3")), /* CTS */ }; +static const unsigned int sun8i_a33_pinctrl_irq_bank_map[] = { 1, 2 }; + static const struct sunxi_pinctrl_desc sun8i_a33_pinctrl_data = { .pins = sun8i_a33_pins, .npins = ARRAY_SIZE(sun8i_a33_pins), .irq_banks = 2, - .irq_bank_base = 1, + .irq_bank_map = sun8i_a33_pinctrl_irq_bank_map, .disable_strict_mode = true, }; diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c index 496ba34e1f5f..6704ce8e5e3d 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c @@ -293,11 +293,13 @@ static const struct sunxi_desc_pin sun8i_v3s_pins[] = { SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 5)), /* PG_EINT5 */ }; +static const unsigned int sun8i_v3s_pinctrl_irq_bank_map[] = { 1, 2 }; + static const struct sunxi_pinctrl_desc sun8i_v3s_pinctrl_data = { .pins = sun8i_v3s_pins, .npins = ARRAY_SIZE(sun8i_v3s_pins), .irq_banks = 2, - .irq_bank_base = 1, + .irq_bank_map = sun8i_v3s_pinctrl_irq_bank_map, .irq_read_needs_mux = true }; diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h index 466840d886f6..4a892e7dde66 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h @@ -110,7 +110,7 @@ struct sunxi_pinctrl_desc { int npins; unsigned pin_base; unsigned irq_banks; - unsigned irq_bank_base; + const unsigned int *irq_bank_map; bool irq_read_needs_mux; bool disable_strict_mode; }; @@ -265,7 +265,10 @@ static inline u32 sunxi_pull_offset(u16 pin) static inline u32 sunxi_irq_hw_bank_num(const struct sunxi_pinctrl_desc *desc, u8 bank) { - return desc->irq_bank_base + bank; + if (!desc->irq_bank_map) + return bank; + else + return desc->irq_bank_map[bank]; } static inline u32 sunxi_irq_cfg_reg(const struct sunxi_pinctrl_desc *desc, -- 2.15.1