Received: by 10.213.65.68 with SMTP id h4csp418030imn; Fri, 16 Mar 2018 07:12:11 -0700 (PDT) X-Google-Smtp-Source: AG47ELseM+OcofWaX6wm8VnslUjqj6HQcPARY1Xp/w9fKmESWX54z0+LnHOzBin/iAjYzuOIaRqS X-Received: by 2002:a17:902:b10f:: with SMTP id q15-v6mr470073plr.263.1521209531362; Fri, 16 Mar 2018 07:12:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521209531; cv=none; d=google.com; s=arc-20160816; b=Y8V214kPF2ckOc481//hicITuMQgcGLQdC/Y27PF+BxaOOHKFAnDx+X5+SO24ui3vZ bCzAg30NgYaGmo50LzxLDWkWWCDDGpVLhrbjDy0DO+RfsriIyIhd8vmZeWSTPeG0iNQy XZ3OLUfnCUtbXJaYvU8Q8CWDq0Drq/nnFGpxHj4Aqjq4+orkSC46TAHMssaMfyfY7Iqn O13e5nmNqeklPtLvGOkPOWZuczYcDdgnsIKQDQeaOKOyXVOmmOPDMtKqFLqHKJC3rMg3 2waxGdG1kjPDk2zxMRuUjsMZhiNRpDFsxCbQTAbqZ3lE4SF1EManeOpz6sTMaAXuzjlF 7Tng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=R6yRk4ba91bJ1rpN04FNVnCaPtmD0IYFvnfjsJhQ7+E=; b=PXfmzdncx9Ry2CIW4UGYC/Cnn4iTQSllmOaiuIWndoWekgQZDgDjodbrOkLdwoRIlq mOTVhDdr4vH1VxPsimRZa5aEoruqbSknKk51aS++Zf66mTfIT+/wxFJ1ULnDoRRN9k7/ peZC+HggIZH+hbJ94pnOQ2YAUXEtnCJ8pLtCksVskgaoti1BsANTfSjMyZEOBCiEGESM dxZuE+hawfOf+Bq0cjXBdIS4vpymvA8SE5cLpSh4F8ZP8hJUATl3IqvK99mP+xDOqDxy 1JZbYmq6LMODzD6+A4b82ZpU0qGtbXg4/8XP23cNdvmu5i1RPkqq4au09zPeU+gJfZP/ XaaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4si4977387pgc.267.2018.03.16.07.11.57; Fri, 16 Mar 2018 07:12:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbeCPOJT convert rfc822-to-8bit (ORCPT + 99 others); Fri, 16 Mar 2018 10:09:19 -0400 Received: from ozlabs.org ([103.22.144.67]:57249 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752843AbeCPOIx (ORCPT ); Fri, 16 Mar 2018 10:08:53 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 402nPY6WKLz9sLv; Sat, 17 Mar 2018 01:08:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Christophe LEROY , Mathieu Malaterre Cc: linux-kernel@vger.kernel.org, Paul Mackerras , Jiri Slaby , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 04/21] powerpc: Mark both tmp variables as unused In-Reply-To: <3f881ec2-eb0f-77e6-f1c5-95530b8f84ad@c-s.fr> References: <20180225172236.29650-1-malat@debian.org> <20180225172236.29650-5-malat@debian.org> <3f881ec2-eb0f-77e6-f1c5-95530b8f84ad@c-s.fr> Date: Sat, 17 Mar 2018 01:08:49 +1100 Message-ID: <87tvtgglji.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe LEROY writes: > Le 25/02/2018 à 18:22, Mathieu Malaterre a écrit : >> Since the value of `tmp` is never intended to be read, declare both `tmp` >> variables as unused. Fix warning (treated as error in W=1): > > What about using fault_in_pages_readable() instead ? Yeah that looks like it would work. I'd be happy to take a tested patch :D cheers