Received: by 10.213.65.68 with SMTP id h4csp441971imn; Fri, 16 Mar 2018 07:54:53 -0700 (PDT) X-Google-Smtp-Source: AG47ELteAoTxO2XBGn9vrYWL4bbYos1dJhi/y6pHHJ1CztZaDF8+EVXcuzw3rHTbdqzzrMsM2ktI X-Received: by 10.101.72.199 with SMTP id o7mr1677003pgs.303.1521212093808; Fri, 16 Mar 2018 07:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521212093; cv=none; d=google.com; s=arc-20160816; b=ox9FKhrIn35BWZEqD1SdoX8j3ore8ti6MZF8sZozgTlIIIBz3MBcWCQeVOfBlOt872 WTMdeCvmQvmy+zgAcQ/FwIV7qpU0ZahpKY4SMmAOgQ6eoxjUNnuZvOh0HkjM4xe/3O1n xOoexWc16hbVcbFNOlpAuQ0lb2JBsFazU699AbtiQB2TzuIcS2dWNQf+4XRUcb/hbIDT QLL58d9yi9/Ih6KJUjAM6TQTmhVaPV78PjXTIJt8WUAsS43PGeymyu104DM3CgFkyXGr 7DeORhE7EdjD//cIa8KnfGiO1KLIVCWb7855iDATNNWpx1rQw5/MP79uZEIym9nNSDYn 23qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=GvtPmvRqB9FJDPLQHV7s5MoKCHNvwsdGNkFJuntZ8KY=; b=eGRl89mQZXYDBfuHCR5v6D0bgC4BXk2B4hoR52RKmRlyPVCs4OMatBFCDIQukmQv3H 9Cax4QUI0chOCHSFUoFSAII1t2W5kVQCOrGzNPGA1+nVuRj8sk81YP/QkNwKMTA5zc/+ 1UlLxuzggW/nVcgv7KokA72frihbq3kAClhyKA201tnJfsYoz1MTRFBd1XmhBBEc+mGM n+LreBMkjA+zL/i1y5jmUtCcJTbo6RJX/kKxNi6Wg/RNPGJpe6Jr7Y8ToQ4QZwi/qg4j bT26/K7PamDhQrlHNxbRVDTaNp7TkbPJUUkcDJMf1hM9ToclpQQbL9uXY6+JRTvyD7QZ ROAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e67si5053999pgc.274.2018.03.16.07.54.39; Fri, 16 Mar 2018 07:54:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905AbeCPOxn (ORCPT + 99 others); Fri, 16 Mar 2018 10:53:43 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753572AbeCPOxk (ORCPT ); Fri, 16 Mar 2018 10:53:40 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2AA794036114; Fri, 16 Mar 2018 14:53:40 +0000 (UTC) Received: from localhost (dhcp-10-15-49-227.lga.redhat.com [10.15.49.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id DFA1284459; Fri, 16 Mar 2018 14:53:39 +0000 (UTC) Date: Fri, 16 Mar 2018 10:53:39 -0400 (EDT) Message-Id: <20180316.105339.409351441331109496.davem@redhat.com> To: doshir@vmware.com Cc: netdev@vger.kernel.org, ntanaka@vmware.com, skhare@vmware.com, pv-drivers@vmware.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/2] vmxnet3: avoid xmit reset due to a race in vmxnet3 From: David Miller In-Reply-To: <20180313194008.12852-1-doshir@vmware.com> References: <20180313194008.12852-1-doshir@vmware.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 16 Mar 2018 14:53:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 16 Mar 2018 14:53:40 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'davem@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ronak Doshi Date: Tue, 13 Mar 2018 12:40:08 -0700 > @@ -977,6 +977,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq, > { > int ret; > u32 count; > + int numPkts; > + int localTxNumDeferred; > unsigned long flags; > struct vmxnet3_tx_ctx ctx; > union Vmxnet3_GenericDesc *gdesc; Please use local variable names with all lowercase letters.