Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 16 Mar 2018 17:05:55 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     ShuFan Lee <leechu729@gmail.com>
Cc:     greg@kroah.com, linux@roeck-us.net, shufan_lee@richtek.com,
        cy_huang@richtek.com, jun.li@nxp.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH] staging: typec: rt1711h typec chip driver
Message-ID: <20180316150555.GE11689@kuha.fi.intel.com>
References: <1521191569-21221-1-git-send-email-leechu729@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1521191569-21221-1-git-send-email-leechu729@gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi ShuFan,

On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote:
> +static int rt1711h_init_gpio(struct rt1711h_chip *chip)
> +{
> +	int ret;
> +	struct device_node *np = chip->dev->of_node;
> +
> +	ret = of_get_named_gpio(np, "rt,intr_gpio", 0);
> +	if (ret < 0) {
> +		dev_err(chip->dev, "%s get int gpio fail(%d)\n", __func__, ret);
> +		return ret;
> +	}
> +	chip->irq_gpio = ret;
> +
> +	ret = devm_gpio_request_one(chip->dev, chip->irq_gpio, GPIOF_IN,
> +				    dev_name(chip->dev));
> +	if (ret < 0) {
> +		dev_err(chip->dev, "%s request gpio fail(%d)\n", __func__, ret);
> +		return ret;
> +	}
> +
> +	chip->irq = gpio_to_irq(chip->irq_gpio);
> +	if (chip->irq <= 0) {
> +		dev_err(chip->dev, "%s gpio2irq fail(%d)\n", __func__,
> +			chip->irq);
> +		return -EINVAL;
> +	}
> +	return 0;

"rt,intr_gpio" should probable be "rt,intr-gpio". Then this function
can be prepared for all types of platforms:

static int rt1711h_init_gpio(struct rt1711h_chip *chip)
{
        struct gpio_desc *gpio;

        gpio = devm_gpiod_get(chip->dev, "rt,intr", GFP_KERNEL);
        if (IS_ERR(gpio))
                return PTR_ERR(gpio);

        chip->irq = gpiod_to_irq(gpio);
	if (chip->irq < 0)
		return chip->irq;

	return 0;
}


Thanks,

-- 
heikki