Received: by 10.213.65.68 with SMTP id h4csp483047imn; Fri, 16 Mar 2018 09:06:29 -0700 (PDT) X-Google-Smtp-Source: AG47ELvn95+P0r3pOOch3pUNpvP9V9OdEfADF4DDAy92glV1MOckekL9FTIhOisQWu6DHL/kFh6U X-Received: by 10.101.88.196 with SMTP id e4mr1853850pgu.162.1521216389811; Fri, 16 Mar 2018 09:06:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521216389; cv=none; d=google.com; s=arc-20160816; b=QU8JEgffw9uwG0u+z+02CA43O/FLISPUQ+dpoO2QZ96xS/1g/2i7Atb93Kg0AVQcUH KnYY+7QfRRJtZtqK+Wp2ufaYD6+eeVgHfJn2g5O2yZL/f8EhcLTqNdg2qIKVTEgWko3k 9/qJB081VzUKgk6ZaDBnxrpFt1XWCmf3pW87Cr1XmInnQXEWjFtH6X1L8oLYp1P+tes5 hA2SGusUUMlI09zzBsO3+YqWzu1gGRIQjDJLUjY0bsysFGva45uhKCAddFqB4j4lnKPP DDKQPBd/X1M30B8Muyz0/0WRf7NehVLFEpNV0z40GL0MOW9MR4SgbqLhsWqHADZZGMac RELg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=T4mbkmwpkjRDiG0tEPRM0v3/X4UCXwl8gHHVv2SwccA=; b=JlRI5olRSrHOXhn1qmuzwy17aVbx72JREQVC/DQqMqRLxw0gQ6NL7FWa1OU48pkZh9 CCMjwhpPh+kYQgtdg6qMo1rxn8MaOxneG/ihXMhn74ntbard5xkQ739tytY3Hm2yLpVq /cKLaHBX2kDF9Divmn484atU02dQj/EjT7ym39iOHDqtSVw4zfEjkY/+oJEDrqy3DbrI ffantHv0dYYM33kybK0Bs7fdoY4CQoxGtpDk64WRJoJyaAxOA1nBiUdu1JrjW6Kn+OqO fCxUfIsUPk84r44SzYwkgR2VFFNzcADXb3puqkayAhMYnSXo/pF8wb1TRyaNNHx05Ljq 8dSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si6457921ply.528.2018.03.16.09.06.16; Fri, 16 Mar 2018 09:06:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934683AbeCPQDe (ORCPT + 99 others); Fri, 16 Mar 2018 12:03:34 -0400 Received: from mga09.intel.com ([134.134.136.24]:39792 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934671AbeCPQDa (ORCPT ); Fri, 16 Mar 2018 12:03:30 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Mar 2018 09:03:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,316,1517904000"; d="scan'208";a="38587886" Received: from sbauer-z170x-ud5.lm.intel.com (HELO sbauer-Z170X-UD5) ([10.232.112.135]) by fmsmga001.fm.intel.com with ESMTP; 16 Mar 2018 09:03:29 -0700 Date: Fri, 16 Mar 2018 09:38:09 -0600 From: Scott Bauer To: Jens Axboe Cc: Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Subject: Re: [PATCH v2] block: sed-opal: fix u64 short atom length Message-ID: <20180316153808.bwhyhwxgne7oqtoh@sbauer-Z170X-UD5> References: <1520379912.4178.83.camel@intel.com> <20180301132700.1279-1-jonas.rabenstein@studium.uni-erlangen.de> <20180307165556.2618-1-jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307165556.2618-1-jonas.rabenstein@studium.uni-erlangen.de> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2018 at 05:55:56PM +0100, Jonas Rabenstein wrote: > The length must be given as bytes and not as 4 bit tuples. > > Signed-off-by: Jonas Rabenstein > --- > v2: > - use fls64 > - shorten loop body > --- > block/sed-opal.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Scott Bauer Tested-by: Scott Bauer Hi Jens, When you get time can you apply this if you have no objections? Thanks