Received: by 10.213.65.68 with SMTP id h4csp483792imn; Fri, 16 Mar 2018 09:07:41 -0700 (PDT) X-Google-Smtp-Source: AG47ELv8P5Zr5n8Oue0amQtCpLRMFkSLGop5SP2KpIKK174S/nNoHugl1kF43omLwdD/tp3x/aIn X-Received: by 2002:a17:902:52c8:: with SMTP id a66-v6mr2768642pli.179.1521216461527; Fri, 16 Mar 2018 09:07:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521216461; cv=none; d=google.com; s=arc-20160816; b=t5scmhRFf5rL+lYtCYuPwuRlgLlnEe9iILxA9EVZ60XXoOW7rS6HXIcBAeHEd8sPeR YXNSPwCjnRm6QgzcnePIyIztYdX0XeBKickUZ1lA3JKU9BUVEuXLjEXg3pRPk9DCoC9L 2cIFT5zL96VHuc0tSA2tj+OmSsJZZFUSTsakgD0bW2SQtQ/51YHD4DAryXuwcNuIzCvF j0ER40WoPPEQNZhs+VdM1q3m0yJF4O0QIeHLaGZyq/OQvYbdtN3vWmF4buN0JPg00tlH vchuFWUYdDkXKfXpv3yzorEKZT2XzxGur+1PxeUs8PzxUs0vC8HDnLgXvFtnwe/Ya58o Oe4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=pctmddwE34A0WbaDOAN7UuoBgw/hH6Cs9oR8XKojPCY=; b=FAPoL7O3zSPQPIj7bDAvdcEfcWzxEKYQiG5C625bB6ykjdRN5eBf3oMfIKe1FvFYGs PFST+U5YgTfYNfFc7PtYR5ySJybCSgc873fzJ7vwB+toYy0d7Kj53HhWanEDRa6MGcsX F9xOifgUbYjcaXWxVm094t8gBooT54z/6Ak1fEB4k9IrFgi5/0ESKVRVYzX6TiyBMQmp WnLfiK+GfNuezt3cp2Y/rb3MASazigAodM6VQkAicgFAyi2SrxraUK+arPa/JkE3m3lb 11b2hVMHkU8PxkeGn48w8nqXfrGn9cVOOanEFBokM+vm/yGFEFHNLl1jFV1t1SlNb9bl iHqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5si5090906pgt.823.2018.03.16.09.07.26; Fri, 16 Mar 2018 09:07:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbeCPQGS (ORCPT + 99 others); Fri, 16 Mar 2018 12:06:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754537AbeCPQGQ (ORCPT ); Fri, 16 Mar 2018 12:06:16 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 890EA20CC6; Fri, 16 Mar 2018 16:06:15 +0000 (UTC) Received: from flask (unknown [10.43.2.80]) by smtp.corp.redhat.com (Postfix) with SMTP id 5299BDEEC8; Fri, 16 Mar 2018 16:06:10 +0000 (UTC) Received: by flask (sSMTP sendmail emulation); Fri, 16 Mar 2018 17:06:09 +0100 Date: Fri, 16 Mar 2018 17:06:09 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, x86@kernel.org, Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "Michael Kelley (EOSG)" , Mohammed Gamal , Cathy Avery , Bandan Das , Thomas Gleixner , Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 7/7] x86/kvm: use Enlightened VMCS when running on Hyper-V Message-ID: <20180316160609.GD5180@flask> References: <20180316142220.32506-1-vkuznets@redhat.com> <20180316142220.32506-8-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180316142220.32506-8-vkuznets@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 16 Mar 2018 16:06:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 16 Mar 2018 16:06:15 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'rkrcmar@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-03-16 15:22+0100, Vitaly Kuznetsov: > Enlightened VMCS is just a structure in memory, the main benefit > besides avoiding somewhat slower VMREAD/VMWRITE is using clean field > mask: we tell the underlying hypervisor which fields were modified > since VMEXIT so there's no need to inspect them all. > > Tight CPUID loop test shows significant speedup: > Before: 18890 cycles > After: 8304 cycles > > Static key is being used to avoid performance penalty for non-Hyper-V > deployments. > > Signed-off-by: Vitaly Kuznetsov > --- Looks good, thanks. Reviewed-by: Radim Krčmář