Received: by 10.213.65.68 with SMTP id h4csp489304imn; Fri, 16 Mar 2018 09:17:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELstkMHq5FF9zYhD8NwKjtOKTQtzNl15BB2qF5rMI9WnruXhCpjenYdaYe8GZOae7KtOqfnT X-Received: by 10.98.201.88 with SMTP id k85mr2053182pfg.9.1521217030181; Fri, 16 Mar 2018 09:17:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521217030; cv=none; d=google.com; s=arc-20160816; b=LBZX3fN2sqPxuHueBMEzFixH5+aVOJCV1sWpEgz4raXzVLsJAwqDkJNOJRkYBOb0rq QCqMYqzcBH1PpLLcimLijnDx/glH5pqIBw0IwqyxWJLMMa8Fyb/j7d/A644EgQeHyCxv 4FqwAkGpFTAiGAin0SJ+tZALdDd7K8WoxnGFcAG2fnblvN57Ei15xiWxIlEvCeHUu+y2 RJZ7eB0v0pxB9yJpo9M8TgmSP9GIpWatoc2LryMMoTvjepm6CMORPiaQHqq+e20mwgft JYvIwI9Fe30PNtK9A03tpryt3icdxposqAwB6wEJRtS0ejfe5/OTJHtMVUayC4/sLTY5 okFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=DAZSHgskz7Y/7FyR3c06pnC7g9EsrbLW1N5XF13gMPY=; b=bHaJ3ov+Tq9EW1WB2K/9PFMXl+9WTT1JEMOoRyVGPrSpb6G9RQlLBQsiFfCZRgMw/M OFenmBDCA6VSAeh0yjZhdobUbcZ46z4fS8xUNH4CD97pwz3huyfu1xXAgr7qaqXti1nH FIN14TJhKA2SlHb0VHMrC2YlPAEezx8I8MkmM+QQFmELk/yWeU22lCv796n9CY9IWm0k VCVOn5I8Xvj+JTs+atu4oMz797YZfJ/9SwEFl62KpOj9QHViDuNO6ivQ9MJrAE3bRnLX HIpAAgYGxcyndkwSqykaaWNEMKO0W/BR9YkHi+aJhSh5g4OH5M0FV6D0chEIrw5IQX19 L9hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0Gv9xL5z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si5228773pge.694.2018.03.16.09.16.55; Fri, 16 Mar 2018 09:17:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0Gv9xL5z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965034AbeCPQO5 (ORCPT + 99 others); Fri, 16 Mar 2018 12:14:57 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33260 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934677AbeCPQOy (ORCPT ); Fri, 16 Mar 2018 12:14:54 -0400 Received: by mail-pf0-f195.google.com with SMTP id q13so4330488pff.0 for ; Fri, 16 Mar 2018 09:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DAZSHgskz7Y/7FyR3c06pnC7g9EsrbLW1N5XF13gMPY=; b=0Gv9xL5zfsIu9RHaittKLPyXoyOF0TXOMQKmaGoElb6d/TZlZUD1yZLsYfAzu5G0ct T2IRCVjqQWyhkHf0NzuUvUJl6Akg7wjDO2PjhnevMTWTUnPgSa+071V+8UYxVBOjAsif zoSH9WDCj0FUa0if4o5KUl9Rn8ahvPRmiV6R6Bg3+frAlU45HAqltt3rDWsBx5fVd3PE oDogqL3MXdBI42Ta5yTlX8oF5rN2Tv+8VQGRfcW3kJg7Fucw0I8R+iFXqsGdeB2KT15z qBMs4ZRyyGENqPR5OiEdfDU73MgahcJcumLvTN6QDazVn1iLhdCn25bV+A+zn3sIlBnV EtIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DAZSHgskz7Y/7FyR3c06pnC7g9EsrbLW1N5XF13gMPY=; b=hMfFBnjhNVaJ8C1AeWFF9AfoeSz1KOv3ovZixifmtPf7VVUyrv231GA/zVBltJz9xd ky+qg/CecSb5hHBkyPX1W2pp94RMhOE3bZ3GDq7k6/vZvw0qrzCvngZLHUpwiRrECZ44 f7tVxHXFJMpMV8kE7NWgIPsrJ4GuV9uBjTuhUCitk7PYzoXTTSusQyh5uykTP9SDlFGO QLYzxREiTZ1o2qN1/Z17dk1yiDiloHl+WtDQ5zwlPVj5rIzNOyWwTuty3IU5gsH56xyL JzOAYSFmfQeMgMqFmDW80ZQ+CcyO9Ltw7cMVvEK6PCTUKDgo/ZBUTv4caUFgFfGlDGTC PKaw== X-Gm-Message-State: AElRT7HH2IKiGMNLsTyTjdFtYpSbkmYLqF0TolTaMv0tWcvoRgUh7c+/ 8H5RGWAqRQVDANqmzEDW7efmrA== X-Received: by 10.98.217.66 with SMTP id s63mr2016592pfg.209.1521216893864; Fri, 16 Mar 2018 09:14:53 -0700 (PDT) Received: from [172.20.1.108] (71-95-160-189.static.mtpk.ca.charter.com. [71.95.160.189]) by smtp.gmail.com with ESMTPSA id d75sm15679487pga.38.2018.03.16.09.14.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Mar 2018 09:14:52 -0700 (PDT) Subject: Re: [PATCH v2] block: sed-opal: fix u64 short atom length To: Scott Bauer Cc: Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein References: <1520379912.4178.83.camel@intel.com> <20180301132700.1279-1-jonas.rabenstein@studium.uni-erlangen.de> <20180307165556.2618-1-jonas.rabenstein@studium.uni-erlangen.de> <20180316153808.bwhyhwxgne7oqtoh@sbauer-Z170X-UD5> From: Jens Axboe Message-ID: <27d404ea-6aa1-6347-fc8d-a8fade43aae8@kernel.dk> Date: Fri, 16 Mar 2018 09:14:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: <20180316153808.bwhyhwxgne7oqtoh@sbauer-Z170X-UD5> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/16/18 8:38 AM, Scott Bauer wrote: > On Wed, Mar 07, 2018 at 05:55:56PM +0100, Jonas Rabenstein wrote: >> The length must be given as bytes and not as 4 bit tuples. >> >> Signed-off-by: Jonas Rabenstein >> --- >> v2: >> - use fls64 >> - shorten loop body >> --- >> block/sed-opal.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) > > Reviewed-by: Scott Bauer > Tested-by: Scott Bauer > > Hi Jens, > > When you get time can you apply this if you have no objections? Done. -- Jens Axboe