Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180316150555.GE11689@kuha.fi.intel.com>
References: <1521191569-21221-1-git-send-email-leechu729@gmail.com> <20180316150555.GE11689@kuha.fi.intel.com>
From:   =?UTF-8?B?5p2O5pu45biG?= <leechu729@gmail.com>
Date:   Sat, 17 Mar 2018 01:47:01 +0800
Message-ID: <CAFaeLdS5zLz+E0M32J47QBfxR_0EkM7erEJCdHnQ__G4R7XYCA@mail.gmail.com>
Subject: Re: [PATCH] staging: typec: rt1711h typec chip driver
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Greg KH <greg@kroah.com>, Guenter Roeck <linux@roeck-us.net>,
        =?UTF-8?B?c2h1ZmFuX2xlZSjmnY7mm7jluIYp?= <shufan_lee@richtek.com>,
        =?UTF-8?B?Y3lfaHVhbmco6buD5ZWf5Y6fKQ==?= <cy_huang@richtek.com>,
        Jun Li <jun.li@nxp.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Heikki,

2018-03-16 23:05 GMT+08:00 Heikki Krogerus <heikki.krogerus@linux.intel.com=
>:
> Hi ShuFan,
>
> On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote:
>> +static int rt1711h_init_gpio(struct rt1711h_chip *chip)
>> +{
>> +     int ret;
>> +     struct device_node *np =3D chip->dev->of_node;
>> +
>> +     ret =3D of_get_named_gpio(np, "rt,intr_gpio", 0);
>> +     if (ret < 0) {
>> +             dev_err(chip->dev, "%s get int gpio fail(%d)\n", __func__,=
 ret);
>> +             return ret;
>> +     }
>> +     chip->irq_gpio =3D ret;
>> +
>> +     ret =3D devm_gpio_request_one(chip->dev, chip->irq_gpio, GPIOF_IN,
>> +                                 dev_name(chip->dev));
>> +     if (ret < 0) {
>> +             dev_err(chip->dev, "%s request gpio fail(%d)\n", __func__,=
 ret);
>> +             return ret;
>> +     }
>> +
>> +     chip->irq =3D gpio_to_irq(chip->irq_gpio);
>> +     if (chip->irq <=3D 0) {
>> +             dev_err(chip->dev, "%s gpio2irq fail(%d)\n", __func__,
>> +                     chip->irq);
>> +             return -EINVAL;
>> +     }
>> +     return 0;
>
> "rt,intr_gpio" should probable be "rt,intr-gpio". Then this function
> can be prepared for all types of platforms:
>
> static int rt1711h_init_gpio(struct rt1711h_chip *chip)
> {
>         struct gpio_desc *gpio;
>
>         gpio =3D devm_gpiod_get(chip->dev, "rt,intr", GFP_KERNEL);
>         if (IS_ERR(gpio))
>                 return PTR_ERR(gpio);
>
>         chip->irq =3D gpiod_to_irq(gpio);
>         if (chip->irq < 0)
>                 return chip->irq;
>
>         return 0;
> }
>
>
> Thanks,
>
> --
> heikki

  Thank you, I've changed it in PATCH v2.

  May I add you to Suggested-by list?

--=20
Best Regards,
=E6=9B=B8=E5=B8=86