Received: by 10.213.65.68 with SMTP id h4csp564886imn; Fri, 16 Mar 2018 11:40:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELtsIXs9f3A23diFyeqrtcV/m4m+qHzRJeH3q0R5zl/XLjVWGUNAqdHbVOe+zxuwQVDkNQLq X-Received: by 2002:a17:902:6f01:: with SMTP id w1-v6mr3158610plk.196.1521225610494; Fri, 16 Mar 2018 11:40:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521225610; cv=none; d=google.com; s=arc-20160816; b=IR29/j2R05FSYuFETRbee3U6B22Zu/0IetNwZAWPN4Q5aA9GiTdpcVt5dYJ/OuLlZS z0cVji8XBRTXKgOF5hvmhLSs0lcNCoL4C1Z2loJozyJgJ66E3cUZQxybF7KZ73WVyCGs YkPXIZwzGZgGth8giuIkAHBL74gQaARY5OizS4r1YN2MIAJ2x7YnOYKhLfEZfw9eGqVC Hl8ivgCkru1oxt1d+AxgukBnhCb/onyxp8qCTl6Kqqz7IKjsli1KaooAvOJyk4ybGKfi XAh11EjMxNrPxRD3kn1OtgKmQ4C0VqGsylfsbUQDoxlnvXq69F/NR41PhvoSCTpwSEr2 R/rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=GY0BqaFGqGzDTgqWrX2i05en7iMMs0rSCZ3JQ+MuIRU=; b=IOyMfnrb9IphbN6u/De8cVJYcIdSfwwxdMOofiGDvdR0N+PKXtwRU76jUn3FKZ9SJt kE0T8v+cirkx28HcSkXvev/6x5rZ3Jn23GqpGvlnwr2Sa1lnYWTb8cUX/Jdb0mf1aPc2 EUMRUCeT+MLgFpyZjzUEzC/SHa+APnPHiQgZaDGgqcrZxgYe5UdY3nMhTOP6DxK3/Ysu y1PvHkFb+1lsYELZvkStMtphCdwi5fe6IhEKjAYQ3XpWHXq33g7Amoy+O8Cyeqgd+BLn Mwp0+xtYM/OeKMzP2LIuDVQ9/HN9xR2Q/1vGzf0J+9dsqanatFi/5MX1C5ybbb8QrIil UQqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e6h+d+1E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5-v6si6703813pll.90.2018.03.16.11.39.55; Fri, 16 Mar 2018 11:40:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e6h+d+1E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbeCPSip (ORCPT + 99 others); Fri, 16 Mar 2018 14:38:45 -0400 Received: from mail-qt0-f171.google.com ([209.85.216.171]:38932 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbeCPSil (ORCPT ); Fri, 16 Mar 2018 14:38:41 -0400 Received: by mail-qt0-f171.google.com with SMTP id v11so3950622qtj.6; Fri, 16 Mar 2018 11:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GY0BqaFGqGzDTgqWrX2i05en7iMMs0rSCZ3JQ+MuIRU=; b=e6h+d+1EQ/uS6RCP6u7+lpHM3bVCU1tUaCEWboBXjnAqsMWJ/X/Emaa4OdaQgSt5d2 mUJdAqb1d/BDsKVlASTPl84djz+BwN4PTCIUzt7KsANQOuHl05TzKhHJZG03j5hvkHNj T3/84EVhFT9GZbr9QYN9Mb8qwgdIOqUNwttsKY3wjSNILHKhRwPJ785BNltaCfJPuQYM jsVO82Q7B2XA9mFD+W/BTWhRoCT55QQF5vBSQ/bOGVHE6u8TZxiaasFTpQ9RQGjUxZoW oomzF/eoRiUN9BrHRUENGs0HKQTM/X/K74ajxy75Z9Oo6iYkfaLFA0GXH6T94WBPi9aQ pCzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GY0BqaFGqGzDTgqWrX2i05en7iMMs0rSCZ3JQ+MuIRU=; b=WdLC9zgs7YR6ITf0SikuKo6OsNaKgtiVghnjq2UagZOfs/4Bf10g7uhXJhSMYn1i1M TT8tUvy+qcxQWbc6Lmx2UT4GFunC4EQcEe5TpvrWfWCD/eler/1xWfDjmIbXN2SGWPJP rd3+wBGz8yFv62VTjadMSsKCXRijngLNmJKkFTgWI74HKSXqGCHkHrt9h2VAkhhCTaEN KvSohI28TkiLtm2uWdpP/2dhy3lpAUZCDhDSPDx0PD/23FJZV8vOIK99uicCGt5vLcgD 7F+C5rVUqO2ccdWvDZZF8J//XaNBr86Nx7MpADHg8sJIhmjeK345TVLtxFtWZY7zuXcr ZINQ== X-Gm-Message-State: AElRT7Erdxh1deByuyMQzVWlnXUQOaV6P4+SfdPL2GZWScCHPJFT5gcI kZyVfjkzj/zGEfdt5Hwx69o6lVeg8pxdzfW2WCk= X-Received: by 10.237.61.184 with SMTP id i53mr4114503qtf.293.1521225521107; Fri, 16 Mar 2018 11:38:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.137.74 with HTTP; Fri, 16 Mar 2018 11:38:40 -0700 (PDT) In-Reply-To: <20180316110907.GK3523@nataraja> References: <20180316110907.GK3523@nataraja> From: Andy Shevchenko Date: Fri, 16 Mar 2018 20:38:40 +0200 Message-ID: Subject: Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch To: Harald Welte Cc: Kenneth Chan , Linux Kernel Mailing List , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 1:09 PM, Harald Welte wrote: > Hi Kenneth, > > thanks for your fix. I'm not currently using any Panasonic Laptop devices > anymore (After the CF-R series was discontinued), so I'm not able to properly > maintain this driver anymore. > > However, your changes look sound to me (aside from that we don't use C++ style > comments in kernel source code), hence: > > Acked-by: Harald Welte I'm not sure I ever seen the original patch. Patchwork also misses it. -- With Best Regards, Andy Shevchenko