Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 16 Mar 2018 14:41:45 -0400 (EDT)
Message-Id: <20180316.144145.1695554148709004295.davem@davemloft.net>
To:     christian.brauner@ubuntu.com
Cc:     ebiederm@xmission.com, gregkh@linuxfoundation.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        serge@hallyn.com, avagin@virtuozzo.com, ktkhai@virtuozzo.com
Subject: Re: [PATCH v2] netns: send uevent messages
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180316125030.23624-1-christian.brauner@ubuntu.com>
References: <20180316125030.23624-1-christian.brauner@ubuntu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Fri, 16 Mar 2018 13:50:30 +0100

> +static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
> +				struct netlink_ext_ack *extack)
> +{
> +	int ret;
> +	/* u64 to chars: 2^64 - 1 = 21 chars */
> +	char buf[sizeof("SEQNUM=") + 21];
> +	struct sk_buff *skbc;

I hate to be difficult, but please use reverse christmas tree ordering
for local variables.

> +static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
> +			      struct netlink_ext_ack *extack)
> +{
> +	int ret;
> +	struct net *net;

Likewise.

Thank you.