Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270822AbTHKBYM (ORCPT ); Sun, 10 Aug 2003 21:24:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270828AbTHKBYM (ORCPT ); Sun, 10 Aug 2003 21:24:12 -0400 Received: from tandu.perlsupport.com ([66.220.6.226]:29825 "EHLO tandu.perlsupport.com") by vger.kernel.org with ESMTP id S270822AbTHKBYM (ORCPT ); Sun, 10 Aug 2003 21:24:12 -0400 Date: Sun, 10 Aug 2003 21:23:37 -0400 From: Chip Salzenberg To: Willy Tarreau Cc: Albert Cahalan , linux-kernel mailing list , davem@redhat.com, jamie@shareable.org Subject: Re: [PATCH] 2.4.22pre10: {,un}likely_p() macros for pointers Message-ID: <20030811012337.GI24349@perlsupport.com> References: <1060488233.780.65.camel@cube> <20030810072945.GA14038@alpha.home.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030810072945.GA14038@alpha.home.local> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 16 According to Willy Tarreau: > likely => __builtin_expect(!(x), 0) > unlikely => __builtin_expect((x), 0) Well, I'm not sure about the polarity, but that unlikely() macro isn't good -- it the same old problem that first prompted my message, namely that it's nonportable when (x) has a pointer type. -- Chip Salzenberg - a.k.a. - "I wanted to play hopscotch with the impenetrable mystery of existence, but he stepped in a wormhole and had to go in early." // MST3K - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/