Received: by 10.213.65.68 with SMTP id h4csp576909imn; Fri, 16 Mar 2018 12:01:55 -0700 (PDT) X-Google-Smtp-Source: AG47ELvGIB2iazKp4EO/LTba4YT5l8WVSMt8ShJJfItcgo3jlj25pwAUkLMM2Afe4zmmz8+6QqgI X-Received: by 10.101.69.75 with SMTP id x11mr2310852pgr.69.1521226914843; Fri, 16 Mar 2018 12:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521226914; cv=none; d=google.com; s=arc-20160816; b=1DMWalBwku1/qmlcKtK7+lgOHBv2qkRzr3UDBCQQbZ4340kll2d4GHCkG2ns3VmkM8 Fw2Blx4QLvN2HFA3ETGvUjrbt3Eh5VLAiDsYZ6DvHe6opw/hXrdUkv98pMBMB5yXx3d5 Q7/620WNV2YbiO24mDhqoCAwG3GPgSSHdYFmNs5iM6kdeFHoMwo0Xiz3xdX/2FeSoFBr EiuCsLvsn8Qi5dDPTFLAdVNwcSTAGdznc9s+mOoJLKBC+07XcNrv920goMkL1kWLWC+R /aHgx+L6LwI2JCiUKCosf3ZTT005WWejyde7u5cUb7yPfFeV3tOjweok82ML683ddW4g 0+5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=uuAQ5LHP2J2TtYlsQZWQco+P1TxU74toR075q7kOwsM=; b=hrvEHhoJKWkOzO3Yrv4teHtVq+4httvy9otgZULMCkX527Gy2j0nQ5NUBnyQqZREwD plyBUtiNxmCClhMP5bx5G+x6VWo+55EhMmGVfm2/w4JqhfUbMh58w4YkTHq7+uGyMUyn OjnXUGxvZbUoNt3pi6OTVnRmyfZkmqk6041kPLQcsc6+0Ap2F6NK+G/9vQi3n3E39eGa /lK26ASyzwz2gHxD6f0YTA5iKQvE3u/HuRIaYtoa4EQGhr5Hs8kmSmzW/cyvJWsW5l7o mZgqhDw8ayS6aUSX7Ob4MD87IUszHS+x34NiuCtJ2mwfCTSdfmQhbtb8Ml1KdPfp4iC0 v2vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=NoWV8+PX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h71si5413455pgc.3.2018.03.16.12.01.36; Fri, 16 Mar 2018 12:01:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=NoWV8+PX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbeCPTAK (ORCPT + 99 others); Fri, 16 Mar 2018 15:00:10 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:45430 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbeCPTAF (ORCPT ); Fri, 16 Mar 2018 15:00:05 -0400 Received: by mail-qt0-f193.google.com with SMTP id v90so11921629qte.12 for ; Fri, 16 Mar 2018 12:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uuAQ5LHP2J2TtYlsQZWQco+P1TxU74toR075q7kOwsM=; b=NoWV8+PXAKFpvrqJYDgCuD2Tw8SAtRyyf9/PKjt+oYW7CjKYGAwvGupSq3FvmGnEPo M+1V+5EFmanm68XSkIDGPv14p98uenedH7j68LWlpP56VrZi1h/9LBbCNvMELaahTc7W 7Y2jmw636+Ns7wHjVLQjAIkkbz8rjXLCdzQCtZKn141ZpejyyQxZSP0xTQvcZuI4aMy9 xvDvA0NDDGYZV/3Ec/JfLMouU1fB40BOUW+ju8cqpSFGSoO7m9O5TkWDrprIYCS6g/HE q7Cg2bllI8mOPwtzJO6DAuIwN6eKh54A/z7IeMng+OS71LfHowlD/XbKATpM62WqBlao RnCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uuAQ5LHP2J2TtYlsQZWQco+P1TxU74toR075q7kOwsM=; b=fLpte6Weddx1V1Cke2RdrB1dWCfs0a59aW7RkxeA4JeYDYz3aMEHgTgZatzoV9eieP KBQ6u5sC9AscPiRVHCCJFR9NRhcxiMO5Om0Fme5SfuHv+ztMIHuZCkD6SdP1oWvQUGVK gFEOr21+gjFFe3ougrtPUwGce+meZi/0xEDNtTwum6ThB2kG3Mptum+h7kxdiIo1ANbj 0r/tc+bjH9gaUHRQ/Zxp3h5GnSxDvOq37wE1KyhTPflFRtVEt2v0wpsSuU4q4g6GrINo 6xCOimrlSIC83XHsa/skd1+paxpMr7ESNFsQg8J5XjTm7vyKmB1ftCf8zfPsqVH+dFTa Qi1g== X-Gm-Message-State: AElRT7EWu3wOUCQC05JeUAD3SvNreovtiSzQdcFIjqJrqfLMWlpXKxpl lTY8Ae25SDxWnpJ8equyV4AU4A== X-Received: by 10.200.61.90 with SMTP id u26mr4369544qtf.168.1521226803755; Fri, 16 Mar 2018 12:00:03 -0700 (PDT) Received: from localhost (cpe-2606-A000-4381-1201-225-22FF-FEB3-E51A.dyn6.twc.com. [2606:a000:4381:1201:225:22ff:feb3:e51a]) by smtp.gmail.com with ESMTPSA id a12sm2722766qtm.74.2018.03.16.12.00.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Mar 2018 12:00:03 -0700 (PDT) Date: Fri, 16 Mar 2018 15:00:02 -0400 From: Josef Bacik To: Matthew Wilcox Cc: Andrew Morton , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: Re: [PATCH v9 10/61] xarray: Change definition of sibling entries Message-ID: <20180316190001.56clqrub6gy6lzh5@destiny> References: <20180313132639.17387-1-willy@infradead.org> <20180313132639.17387-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180313132639.17387-11-willy@infradead.org> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 06:25:48AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > Instead of storing a pointer to the slot containing the canonical entry, > store the offset of the slot. Produces slightly more efficient code > (~300 bytes) and simplifies the implementation. > > Signed-off-by: Matthew Wilcox > --- > include/linux/xarray.h | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++ > lib/radix-tree.c | 66 +++++++++++------------------------ > 2 files changed, 112 insertions(+), 47 deletions(-) > Reviewed-by: Josef Bacik Thanks, Josef