Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270846AbTHKCKX (ORCPT ); Sun, 10 Aug 2003 22:10:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270856AbTHKCKX (ORCPT ); Sun, 10 Aug 2003 22:10:23 -0400 Received: from mail.jlokier.co.uk ([81.29.64.88]:23685 "EHLO mail.jlokier.co.uk") by vger.kernel.org with ESMTP id S270846AbTHKCKT (ORCPT ); Sun, 10 Aug 2003 22:10:19 -0400 Date: Mon, 11 Aug 2003 03:09:57 +0100 From: Jamie Lokier To: Chip Salzenberg Cc: Willy Tarreau , Albert Cahalan , linux-kernel mailing list , davem@redhat.com Subject: Re: [PATCH] 2.4.22pre10: {,un}likely_p() macros for pointers Message-ID: <20030811020957.GE10446@mail.jlokier.co.uk> References: <1060488233.780.65.camel@cube> <20030810072945.GA14038@alpha.home.local> <20030811012337.GI24349@perlsupport.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030811012337.GI24349@perlsupport.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 17 Chip Salzenberg wrote: > According to Willy Tarreau: > > likely => __builtin_expect(!(x), 0) > > unlikely => __builtin_expect((x), 0) > > Well, I'm not sure about the polarity, but that unlikely() macro isn't > good -- it the same old problem that first prompted my message, namely > that it's nonportable when (x) has a pointer type. It's portable as long as the compiler is GCC :) -- Jamie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/