Received: by 10.213.65.68 with SMTP id h4csp616365imn; Fri, 16 Mar 2018 13:21:53 -0700 (PDT) X-Google-Smtp-Source: AG47ELtJdgLnS5KouKFq6ghjD1E5HTKXiLUoIzdOg2Tne60gup00vV7si4R0RpMI5XvhPjr6H6Nq X-Received: by 10.101.65.11 with SMTP id w11mr2429131pgp.186.1521231713761; Fri, 16 Mar 2018 13:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521231713; cv=none; d=google.com; s=arc-20160816; b=jazmp0EJvTBhAEo1UhSGc+JMIgAOHsgUKr746wUIPv+GDPpD+Py2R+WMwkNRk/7/nm eRnefaFrqaGu/lzrxFUpr9371nkWDN8OZDiib2V/r6m9kZ1PjbN4k064Q06Jicw6HeCm O58REpYZMYIOGGuICO4MkP0KbDdghzbkP2Qllz9Z06V1Ecm11xUJP8UNpsKr3dSA19GD YF3ah71GBDv56xKANx7G11yZxwRaw9+hhgmv1kqcj6wqS7xgHMMmX9KTqBQHeEOy6qeN vrjzFaK8F0l+lMJ85XOGO455kScG3DWYXvY5K040vu6j0rEf9tGNW3f1/6WC7FBdGL0Y TxMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=xRyUIWsLZQH4u6jCYEsy8feys5seDvlptq7ujQkRPDI=; b=goaUcOJ5Px8t4EIjzUUBj2ouiZEa/zrLcLQvmQFzrwp1x1mTvzUkcYWhm2XftUH6WW Qt5imIy4W4kpTaOJdXL4ezKsR503r0r0NJ6RMsHAyVLPqp80hi812FOfR0HCNmhaknXn Cq/baDased3njguLZqt62CI3zlSSN+a2tq14Wera4V8uD+WTM3mWuEZhzrslY+kx8EZm VL6PEmDab6C6Aq6RBV3TarSGUgM31ogm3J9g03LucWmHj3GI27O/gjD028c8NUJxm33t 99M50GrwzpuaqYTIRED1rRVGwE4kYSpuhA9RLoscCUMdXvNm/gxDpLDxbhVHa/+/3Cd7 oJag== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gH9H/K7V; dkim=fail header.i=@linux-foundation.org header.s=google header.b=OOIwvVTO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e28si5504146pgn.464.2018.03.16.13.21.39; Fri, 16 Mar 2018 13:21:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gH9H/K7V; dkim=fail header.i=@linux-foundation.org header.s=google header.b=OOIwvVTO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbeCPUTZ (ORCPT + 99 others); Fri, 16 Mar 2018 16:19:25 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:35668 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbeCPUTV (ORCPT ); Fri, 16 Mar 2018 16:19:21 -0400 Received: by mail-io0-f170.google.com with SMTP id e7so3555791iof.2; Fri, 16 Mar 2018 13:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xRyUIWsLZQH4u6jCYEsy8feys5seDvlptq7ujQkRPDI=; b=gH9H/K7V7i93PnWOhQywtiIh7n1BktCywr96VzRU357gE1++MVSESFD7QFcEpJX6mp 4sW3kP+5QTTDQDNq32/X5mLjey1sotsqVif3InrEwyjywgrCVPC/IxM32cb0bJ+eIYRE K33bqoGKC8v/RTYwS4eVVkX5v8dktFqyq2dssZWI5j01kB3/7Ic2LvDwoPoAHYCY2eUz RJyU0DeusT0lgNU3QtVNNfaHwdZZfBDnqAzUq3H5N6BdkBHuaLqjWngRgwRHHyiUBMpz 2LTT5xmSzQxJ6/Qxyk0InfrKjAQ8xBloW6Ar0/luKQjn5WBjhmFyzwBjIK9C6fKulE9o giBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xRyUIWsLZQH4u6jCYEsy8feys5seDvlptq7ujQkRPDI=; b=OOIwvVTOBzKyse8hUvwSMzd9kw3hqCgDTF8A49CO5HGBg6FMtyE7k65dQIjxfLjW+m eyxLql+F3tMN/Tkc2EOtxxXJXgEA/VrbWKoJTa9AzaCA5JLtSw4Kg6Xlm6r0j6uRY+9y 71h0kfIeGKot4awO+a1FjTBtEhDARrVI3C3+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=xRyUIWsLZQH4u6jCYEsy8feys5seDvlptq7ujQkRPDI=; b=bJ73mNpXT1mvg657eHvCbMYP4fQJNjnmKEoODvb6VgeMFb8LE/86ItFmy2nlWs5AT2 /e3DcQWIY1xf1HtCXBgc2IudDFW2YOoEH1MIGGG5DyEIuAgWkV5gD/O1JP5XoFdLq1hL E/QYzQr4E8U8GXYERE3/yAywsPUA65HilVRzfbVJ+suixsNGJfkHXsXqZVZPc7MIlGMF qtLpBCyIBIjD8HALV1JUK1njAlfOWRLZ8ejTwAZC2wCxhPFw/Xw6jLxub2wNqcoAe543 gmz10yeMV3mU6QDCUZ7L2IfrAfZtla0Wn0EEjg6sL1jRYrHlGMOe3mZuiN9wODEtFx0w TMRA== X-Gm-Message-State: AElRT7FgYtYa4AqUxVjWXeK+iuuvE1ViA1EMC1ld2cIjlltponnxgyGt t5SKiKeltQr3FkNspjS/6MphdIwxRQzs8o/LxtQ= X-Received: by 10.107.186.196 with SMTP id k187mr3249880iof.257.1521231560431; Fri, 16 Mar 2018 13:19:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.135.221 with HTTP; Fri, 16 Mar 2018 13:19:19 -0700 (PDT) In-Reply-To: References: <1521174359-46392-1-git-send-email-keescook@chromium.org> <20180316175502.GE30522@ZenIV.linux.org.uk> From: Linus Torvalds Date: Fri, 16 Mar 2018 13:19:19 -0700 X-Google-Sender-Auth: zDnxcbBvrFBbrRSFvObEM97ii74 Message-ID: Subject: Re: [PATCH v5 0/2] Remove false-positive VLAs when using max() To: Miguel Ojeda Cc: Al Viro , Florian Weimer , Kees Cook , Andrew Morton , Josh Poimboeuf , Rasmus Villemoes , Randy Dunlap , Ingo Molnar , David Laight , Ian Abbott , linux-input , linux-btrfs , Network Development , Linux Kernel Mailing List , Kernel Hardening Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 1:14 PM, Linus Torvalds wrote: > > It does not work with gcc-4.1.x, but works with gcc-4.4.x. > > I can't seem to see the errors any way, I wonder if > __builtin_choose_expr() simply didn't exist back then. No, that goes further back. It seems to be -Wvla itself that doesn't exist in 4.1, so the test build failed simply because I used that flag ;) Linus