Received: by 10.213.65.68 with SMTP id h4csp689imn; Fri, 16 Mar 2018 15:09:35 -0700 (PDT) X-Google-Smtp-Source: AG47ELvs4/UpR1Od+1zPD6qdaPuaqW7H2JHkHvBGANdt8c+ud8Lro70pfVucdHridENc5pOTIr+j X-Received: by 2002:a17:902:127:: with SMTP id 36-v6mr3708091plb.194.1521238175567; Fri, 16 Mar 2018 15:09:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521238175; cv=none; d=google.com; s=arc-20160816; b=a6FOHqeAYE8ikfcB8qMiBFGYPGS9d2+rv0zHQ9RSm6xAxYWEKwWQhnW8qFA6gUCYiP thi6XZyIEm/Hhy8EUtZEzL69c6lpnzPORAtOcS3XdqqM5FjyMuRKhl3oF+hW+0km0X8v kYuxlK1wyM2CKfUfAIY3yADzHDoPvaKgcr4jinQe6ez/o5Yl3mJjeGpslgfmye17J56I QZsg98de0Tm5xPx56QxkbMaMlE0aPosQt1ebz5UmS7aFuD7kAFpDbsxPzbAIyXRXTweM liodbvgyNFT51FI8ndBlBuK4uyNMkN87RkIcxbc98pGKHofSQC2pr/a9AZeVzhtrTmP5 iKAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:cc:references:to:subject:arc-authentication-results; bh=p2Qrwk0vzRsTrAjn9rFZhhsugw7ZyF6TYAmbSPU1FkU=; b=YXJO7Vd7HxL3wFXXsXrsSDo9/105tHqJLFeFUTg9K+NpZgZ4RDzXjHegSlvWtJmjYw /962qTbXiQqU6DrZDpESpKMQEhhZDCRbKlscofCgCyvPQ1QaDO2CgPk79o4Pc3fQ100o AGue5ng+wk/uNJuGTzdxqQaiOreIq860Sv+zVWdNopP6HDgD45+uvcG0o2MjLpBhZkqX x2K0nlvLLjGCOIJxUx2/oBsC7IvzZ+owmjaadW/jaDenUvwk81bqgmgOvok97JcVq0VP WuLUBqmRTmkVyz2THv7AuRcpr23WN/VY4nE2sWuvybPSY5dh71NtZofr+VG5JNOrpsmj 3YbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si5640319pgf.310.2018.03.16.15.09.21; Fri, 16 Mar 2018 15:09:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbeCPWIc (ORCPT + 99 others); Fri, 16 Mar 2018 18:08:32 -0400 Received: from mga04.intel.com ([192.55.52.120]:37259 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbeCPWI3 (ORCPT ); Fri, 16 Mar 2018 18:08:29 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Mar 2018 15:08:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,317,1517904000"; d="scan'208";a="25369515" Received: from ray.jf.intel.com (HELO [10.7.201.16]) ([10.7.201.16]) by orsmga007.jf.intel.com with ESMTP; 16 Mar 2018 15:08:28 -0700 Subject: Re: [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear() To: Ram Pai , shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org References: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> <1519264541-7621-8-git-send-email-linuxram@us.ibm.com> Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, akpm@linux-foundation.org, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, arnd@arndb.de From: Dave Hansen Message-ID: Date: Fri, 16 Mar 2018 15:08:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519264541-7621-8-git-send-email-linuxram@us.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2018 05:55 PM, Ram Pai wrote: > --- a/tools/testing/selftests/vm/protection_keys.c > +++ b/tools/testing/selftests/vm/protection_keys.c > @@ -461,7 +461,7 @@ void pkey_disable_clear(int pkey, int flags) > pkey, pkey, pkey_rights); > pkey_assert(pkey_rights >= 0); > > - pkey_rights |= flags; > + pkey_rights &= ~flags; > > ret = pkey_set(pkey, pkey_rights, 0); > /* pkey_reg and flags have the same format */ > @@ -475,7 +475,7 @@ void pkey_disable_clear(int pkey, int flags) > dprintf1("%s(%d) pkey_reg: 0x%016lx\n", __func__, > pkey, rdpkey_reg()); > if (flags) > - assert(rdpkey_reg() > orig_pkey_reg); > + assert(rdpkey_reg() < orig_pkey_reg); > } > > void pkey_write_allow(int pkey) This seems so horribly wrong that I wonder how it worked in the first place. Any idea?