Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9157221742
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     ALKML <linux-arm-kernel@lists.infradead.org>,
        DTML <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <1519403030-21189-17-git-send-email-sudeep.holla@arm.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Alexey Klimov <klimov.linux@gmail.com>,
        Sudeep Holla <sudeep.holla@arm.com>, linux-clk@vger.kernel.org
References: <1519403030-21189-1-git-send-email-sudeep.holla@arm.com>
 <1519403030-21189-17-git-send-email-sudeep.holla@arm.com>
Message-ID: <152124137391.242365.17144416413429914606@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v6 16/20] clk: add support for clocks provided by SCMI
Date:   Fri, 16 Mar 2018 16:02:53 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Sudeep Holla (2018-02-23 08:23:46)
> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
> new file mode 100644
> index 000000000000..1e4d7a57779b
> --- /dev/null
> +++ b/drivers/clk/clk-scmi.c
> +                       hws[idx] = &sclk->hw;
> +               }
> +       }
> +
> +       return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);

devm_of_clk_add_hw_provider?

> +}
> +
> +static void scmi_clocks_remove(struct scmi_device *sdev)
> +{
> +       struct device *dev = &sdev->dev;
> +       struct device_node *np = dev->of_node;
> +
> +       of_clk_del_provider(np);
> +}
> +

Drop?

You can keep my acked-by otherwise.