Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180309232543.24636-1-ilina@codeaurora.org> <20180309232543.24636-8-ilina@codeaurora.org>
In-Reply-To: <20180309232543.24636-8-ilina@codeaurora.org>
From:   Evan Green <evgreen@chromium.org>
Date:   Sat, 17 Mar 2018 00:36:28 +0000
Message-ID: <CAE=gft6y4yUvjHnSf10+Yt9Sw-bcKdFUWW7zWFRvMgzENe7gUw@mail.gmail.com>
Subject: Re: [PATCH v4 07/10] drivers: qcom: rpmh: cache sleep/wake state requests
To:     Lina Iyer <ilina@codeaurora.org>
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-kernel@vger.kernel.org, sboyd@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer <ilina@codeaurora.org> wrote:

> Active state requests are sent immediately to the mailbox controller,
> while sleep and wake state requests are cached in this driver to avoid
> taxing the mailbox controller repeatedly. The cached values will be sent
> to the controller when the rpmh_flush() is called.

> Generally, flushing is a system PM activity and may be called from the
> system PM drivers when the system is entering suspend or deeper sleep
> modes during cpuidle.

> Also allow invalidating the cached requests, so they may be re-populated
> again.

> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---

> Changes in v4:
>          - remove locking for ->dirty in invalidate
>          - fix send_single
> Changes in v3:
>          - Remove locking for flush function
>          - Improve comments
> ---
>   drivers/soc/qcom/rpmh.c | 203
+++++++++++++++++++++++++++++++++++++++++++++++-
>   include/soc/qcom/rpmh.h |  10 +++
>   2 files changed, 212 insertions(+), 1 deletion(-)


Reviewed-by: Evan Green <evgreen@chromium.org>