Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180309232543.24636-1-ilina@codeaurora.org> <20180309232543.24636-10-ilina@codeaurora.org>
In-Reply-To: <20180309232543.24636-10-ilina@codeaurora.org>
From:   Evan Green <evgreen@chromium.org>
Date:   Sat, 17 Mar 2018 00:36:52 +0000
Message-ID: <CAE=gft4a3m97MnEH1wZXkrLGcKigvUUeozoP1VdN+dupKzwSmA@mail.gmail.com>
Subject: Re: [PATCH v4 09/10] drivers: qcom: rpmh: add support for batch RPMH request
To:     Lina Iyer <ilina@codeaurora.org>
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-kernel@vger.kernel.org, sboyd@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 9, 2018 at 3:26 PM Lina Iyer <ilina@codeaurora.org> wrote:

> Platform drivers need make a lot of resource state requests at the same
> time, say, at the start or end of an usecase. It can be quite
> inefficient to send each request separately. Instead they can give the
> RPMH library a batch of requests to be sent and wait on the whole
> transaction to be complete.

> rpmh_write_batch() is a blocking call that can be used to send multiple
> RPMH command sets. Each RPMH command set is set asynchronously and the
> API blocks until all the command sets are complete and receive their
> tx_done callbacks.

> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---

> Changes in v4:
>          - reorganize rpmh_write_batch()
>          - introduce wait_count here, instead of patch#4
> ---
>   drivers/soc/qcom/rpmh.c | 156
+++++++++++++++++++++++++++++++++++++++++++++++-
>   include/soc/qcom/rpmh.h |   8 +++
>   2 files changed, 162 insertions(+), 2 deletions(-)


Reviewed-by: Evan Green <evgreen@chromium.org>