Received: by 10.213.65.68 with SMTP id h4csp81449imn; Fri, 16 Mar 2018 18:54:48 -0700 (PDT) X-Google-Smtp-Source: AG47ELsHMAAZtC3h6TPVs8Sngx8LHBnoOQHTqYxpglMsP9sGiAYt3JOXCBhmV4/0udNKnpqCw4SJ X-Received: by 2002:a17:902:780d:: with SMTP id p13-v6mr2976986pll.281.1521251688688; Fri, 16 Mar 2018 18:54:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521251688; cv=none; d=google.com; s=arc-20160816; b=jTf0mw1SIRB3nGIjKL5TxcycOaQQtdxpK1aka4qQdCJgeVczL8mPH151XnOEnT5BOB sDfiQiX8wJ5WkfwmWSsIK26BDwkNTPN0dFkRflVQKxGli9MfBPwBQNLKuIe+Dnqd2MyD gY4r4qIzDPf5xmJ+0T58pWYc5C8CfY4hu+19IHB/P+hE7vCQEsx5hWvAp82sscSuGfm6 ZH63d+rH0dOaFj2Xr0UrsJQaUihlk62KHt42qowS/g47E5dcFqM3Jj7kgaTQBj2ZKUs/ UWIejDYQmiom7GdxxbAhxc4eVWTwNRIpyy+vekNHKVoLjGyFaE/0PVk4l6sFkr+SE3vn KMyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=3uISLu9PS2oVDvFCR2wynMQkVmR2APN3F7rYzdeiRFE=; b=0vf0aMHGhuUuWlEf0xBGWz1272JjAf3JVn4N9Ecn7RNfbXMkBGjvl0g4/4nutFfoHh 1coDoafwWq744g6wmaEK4hFSjaJPVFARBAKu+l3YLe0R3lYusPy4MDkrHoH4GQOMR6Zb d8xrbeZFYYv9sSFM19Pj+ihUmr7fddjhqlm6N6lZgjbGRlToiJP/Ac0XRZLWwchcb3U/ 1ZcEPU7oDwLhxGekikg2nt4HhJIb8tLwPhPMNBYxP3XDB1X4tQpIZWipQDWFo6+OH11R DrjRVQeS2Rcen6+BLNJE3H/jNlA6HXBEJglaqJDlnjk/JEZVtVCNEUPGzUVZULa3sxNh QPRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gV06XPV2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9-v6si7224652plr.21.2018.03.16.18.54.34; Fri, 16 Mar 2018 18:54:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gV06XPV2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752916AbeCQBxo (ORCPT + 99 others); Fri, 16 Mar 2018 21:53:44 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36902 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbeCQBxm (ORCPT ); Fri, 16 Mar 2018 21:53:42 -0400 Received: by mail-pg0-f68.google.com with SMTP id n11so48677pgp.4; Fri, 16 Mar 2018 18:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3uISLu9PS2oVDvFCR2wynMQkVmR2APN3F7rYzdeiRFE=; b=gV06XPV2RK5ew326aLEQnfpmOqBG+l0ZUddEp4MqEMEFCz6DaKwiC0TQW1//fKABAG wZ5XVYebo281nkzj9SYV+FRqBIEdCvhpv4JhhgAEvJUWp5bEnAd7Qzx/VruPRyEMsL21 RNH0wNK3zhFy4A0FKHWXmlnb3GIfDsxzHkE9j4WJJ2wsc5CB5w+Wn8XI4xzpVElMadE+ TqnS5FFXwHgrzmx37hIZbIb/NBfPEgxqDtbVQpNkqpkbpSOrMyvJ6MAWpBb/79BJkul8 2qnn9LdtuAUe1r44ksS5/Z/VQ15NzfR0M5yyFo7jz5cmz0O17RLivWkAmWl43zznXLdL CSmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3uISLu9PS2oVDvFCR2wynMQkVmR2APN3F7rYzdeiRFE=; b=friOpPY+PztAVif4tfzvPuoEaKIJU/CE351duuL38JHfiw2TO8de14BcztNTQO765M uCQJguI7KSjX3BT6UJJW+40SZ6Eni0vwLeFgfmEpqs2vmgFBh1suPYWwwgoXUipOXODt EYl+CCSTODhsHwQe1jQCug4sNcj/2amfEHIoATPu5rlYMfV2FX2Z3bVRG7rUvsjnmn36 uND6hn2QMxixDJjsCLCBR3BJrE8H0rfI4FWEWcm5vN0RJv8CEZuD5+p6kNp7VfPsqVr/ KBc9w05KW6s7CfHHdg5blNCyxlcloEb5SJtTd6sen9cVZxBDY0GSeXxylhkw5tJ51IhY sFew== X-Gm-Message-State: AElRT7FsRQCD2E6TSgvHhOhbNfZtgsAJtBaQOQofyZ327c6SforcXNdK quBgiYJXLJS/szPlJFCCaiA= X-Received: by 10.101.77.201 with SMTP id q9mr3075497pgt.395.1521251622218; Fri, 16 Mar 2018 18:53:42 -0700 (PDT) Received: from server.roeck-us.net (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id u10sm16335088pfh.57.2018.03.16.18.53.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Mar 2018 18:53:41 -0700 (PDT) Subject: Re: [PATCH v7 0/2] hwmon: (ucd9000) Add gpio and debugfs interfaces To: Eddie James , linux-hwmon@vger.kernel.org Cc: linux-kernel@vger.kernel.org, jdelvare@suse.com, joel@jms.id.au References: <1521235326-24310-1-git-send-email-eajames@linux.vnet.ibm.com> From: Guenter Roeck Message-ID: Date: Fri, 16 Mar 2018 18:53:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521235326-24310-1-git-send-email-eajames@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/16/2018 02:22 PM, Eddie James wrote: > The ucd9000 series chips have gpio pins. Add a gpio chip interface to the ucd > device so that users can query and set the state of the gpio pins. > > Add a debugfs interface using the existing pmbus debugfs directory to provide > MFR_STATUS and the status of the gpi faults to users. > Series applied to hwmon-next. Thanks a lot for your patience. Guenter > Changes since v6: > - don't return null terminator for mfr_status > > Changes since v5: > - enclose gpio code in #ifdef GPIOLIB > - don't initialize buffers for mfr_status; set last char to 0 instead > - cap the size argument to bin2hex > > Changes since v4: > - max-sized buffers for smbus transfers > - used bin2hex instead of my own code > > Changes since v3: > - remove setting of gpio_chip->owner > - format the mfr_status data > - switch to #ifdef rather than #if IS_ENABLED for debugfs > > Changes since v2: > - split the gpio registration into it's own function > > Changes since v1: > - dropped dev_err messages > - made gpio chip registration conditional on having gpio pins > - made mfr_status debugfs attribute more simple > > > Christopher Bostic (2): > hwmon: (ucd9000) Add gpio chip interface > hwmon: (ucd9000) Add debugfs attributes to provide mfr_status > > drivers/hwmon/pmbus/ucd9000.c | 350 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 349 insertions(+), 1 deletion(-) >