Received: by 10.213.65.68 with SMTP id h4csp137411imn; Fri, 16 Mar 2018 21:32:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELslsPbphN6Rxe+N2Iyc4Ff22ucJfueza7+Mq/xJbN2AwiFtSP2YrM4/7+1j+VfE5ktEWE+D X-Received: by 2002:a17:902:b10c:: with SMTP id q12-v6mr4619448plr.197.1521261129994; Fri, 16 Mar 2018 21:32:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521261129; cv=none; d=google.com; s=arc-20160816; b=YNB2IeadQqIZp2eU3hBdP+4kI/vipkEOoYhDsHszWLv9IIUiKql8aJ4+a5DlIwH1uN zzvw6OSZMQUaOX7/u5VLPj5QRMNoJSMpi04rpIjbKjJwMJG+Bw6fLQhsvm6xLyKbha+O yyHG65qNhYmV0u0DJy3PTlcNKLRG4VkkPB1tkhW+CMeQ59Gl+sv0ON2FRcKtf/LGjIAH xrvJ+DL2kV5H0jy13we6MctEChSuFxQybimNu65jIAO5almrDhFkSxeftxoOg4Vlyxqd VaX8tYP4nxPXfQTSP8XYotc0L6lsxTFC5XHewNAZwZN6UaA8PxSxW85Y+3Oq+eEi4sY7 fknw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dmarc-filter:dkim-signature :dkim-signature:arc-authentication-results; bh=twL6FXq+noWwvBxEBYq7+MAMygUfyviqo/DaX90ZBro=; b=oZy+bGoUpEAx8d78gBNRE98gQoAgM0eYQIQyd4CRcFwugVUuGkuJaC/S1VObVVDrOZ emOGC8vlKlZKf9mhnUEyyVmcu8yOvukqVQRbd4q74w2VsbJDPr4sP5A/08cpxMmf2s6o 74v7MxLpZxN+dwj8G3JvHFL66LjWMJrl9LaWz+PhmpJcE4rgiwUvi5Cb1+HAewGXHV7R crUWqP6CeJlM1rAa+lU+I39CRT508T5he70INoZEQ6rKrLz1h2ND/bV+JcrDRk9pJ9nV DlLhFus20M8VZloAw+jj2GEhau3QCBsABrSrVyohexKH7Fi0RRVtDHoo7e84VUFdF7Zc slRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=nxqi3Kc0; dkim=pass header.i=@codeaurora.org header.s=default header.b=P95ZGDGb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i188si1125179pgc.178.2018.03.16.21.31.54; Fri, 16 Mar 2018 21:32:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=nxqi3Kc0; dkim=pass header.i=@codeaurora.org header.s=default header.b=P95ZGDGb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751604AbeCQEbF (ORCPT + 99 others); Sat, 17 Mar 2018 00:31:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40638 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbeCQEbD (ORCPT ); Sat, 17 Mar 2018 00:31:03 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 56E6560F61; Sat, 17 Mar 2018 04:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521261062; bh=vrGE/B0P/TwcdeX2bbxkVDfvSd4zqInbRY8Wc6pZjwg=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=nxqi3Kc0DlKO69XVssO4/z7eQZizPUFlhwOJT5a5vQSDua+7nFOB/AWnb06Efh9/S HB/+F9V8r+s+Nw5XgzkVjyTOEXgTZ+oNqMG5Et4WP8uY53+l6LpH8frqdacrvuobwU wBurj40E7W1jrXwzD7+tN9UD6jCLKQs+MvI9NXtc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7A58E60C66; Sat, 17 Mar 2018 04:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521261061; bh=vrGE/B0P/TwcdeX2bbxkVDfvSd4zqInbRY8Wc6pZjwg=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=P95ZGDGbU4jXQJQJIsSAGiR7K9Ioinw0dk6VCfc5pXsL0oRYm6mOaKdsT68LiAwN6 ai809wxwGPBMwfFcpzWf+sH//c60lhbfqthvaos3lGUZgHauYBfc4ESvya99bCTXAp LHVjp4ZSiO+DBv3gOWJozPwBF65UCx2No/eRkIls= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7A58E60C66 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Received: by mail-oi0-f50.google.com with SMTP id e9so10319597oii.0; Fri, 16 Mar 2018 21:31:01 -0700 (PDT) X-Gm-Message-State: AElRT7EiSldAXU/oY+9A8qolenvGW15A8xS2O7D/bDfdUwSysuoKwZAw k4Vg81iVkxWLA5F8bC2q2GuqjmWNstrSmXXL8qk= X-Received: by 10.202.8.87 with SMTP id 84mr2642474oii.309.1521261060762; Fri, 16 Mar 2018 21:31:00 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:70d1:0:0:0:0:0 with HTTP; Fri, 16 Mar 2018 21:30:59 -0700 (PDT) In-Reply-To: <1f5e3b14-05a1-08d0-c0cb-00805526448d@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> <1521216991-28706-19-git-send-email-okaya@codeaurora.org> <003601d3bd6a$783d6970$68b83c50$@opengridcomputing.com> <83387f6e-adcb-14e9-2c22-96abf9493cc6@codeaurora.org> <004501d3bd7b$505e70f0$f11b52d0$@opengridcomputing.com> <740c7d45-450e-c9b3-ceed-7bc7fcefbc5a@codeaurora.org> <71e37a55-537b-d75a-cfde-f188b7cfce8e@codeaurora.org> <1f5e3b14-05a1-08d0-c0cb-00805526448d@codeaurora.org> From: Timur Tabi Date: Fri, 16 Mar 2018 23:30:59 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs To: Sinan Kaya Cc: Steve Wise , netdev , Timur Tabi , sulrich@codeaurora.org, Casey Leedom , Steve Wise , linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org, lkml , Jason Gunthorpe , Doug Ledford , Michael Werner , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 11:25 PM, Sinan Kaya wrote: > @@ -477,15 +477,16 @@ static inline void t4_ring_sq_db(struct t4_wq *wq, u16 inc, union t4_wr *wqe) > (u64 *)wqe); > } else { > pr_debug("DB wq->sq.pidx = %d\n", wq->sq.pidx); > - writel(PIDX_T5_V(inc) | QID_V(wq->sq.bar2_qid), > - wq->sq.bar2_va + SGE_UDB_KDOORBELL); > + __raw_writel(PIDX_T5_V(inc) | QID_V(wq->sq.bar2_qid), I think Jason might be right that drivers shouldn't be calling the __raw_write functions. You definitely need to run this by the PPC developers, specifically Ben Herrenschmidt. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.