Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 17 Mar 2018 11:29:03 +0100
From:   Christian Brauner <christian.brauner@canonical.com>
To:     David Miller <davem@davemloft.net>
Cc:     christian.brauner@ubuntu.com, ebiederm@xmission.com,
        gregkh@linuxfoundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, serge@hallyn.com,
        avagin@virtuozzo.com, ktkhai@virtuozzo.com
Subject: Re: [PATCH v2] netns: send uevent messages
Message-ID: <20180317102902.GA4301@gmail.com>
References: <20180316125030.23624-1-christian.brauner@ubuntu.com>
 <20180316.144145.1695554148709004295.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180316.144145.1695554148709004295.davem@davemloft.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 16, 2018 at 02:41:45PM -0400, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Fri, 16 Mar 2018 13:50:30 +0100
> 
> > +static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
> > +				struct netlink_ext_ack *extack)
> > +{
> > +	int ret;
> > +	/* u64 to chars: 2^64 - 1 = 21 chars */
> > +	char buf[sizeof("SEQNUM=") + 21];
> > +	struct sk_buff *skbc;
> 
> I hate to be difficult, but please use reverse christmas tree ordering
> for local variables.

No problem David, coding style is important. I'm about to send out
another version with:

/* u64 to chars: 2^64 - 1 = 21 chars */
char buf[sizeof("SEQNUM=") + 21];
struct sk_buff *skbc;
int ret;

Thanks!
Christian

> 
> > +static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
> > +			      struct netlink_ext_ack *extack)
> > +{
> > +	int ret;
> > +	struct net *net;
> 
> Likewise.
> 
> Thank you.