Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271002AbTHKFU7 (ORCPT ); Mon, 11 Aug 2003 01:20:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S271118AbTHKFU7 (ORCPT ); Mon, 11 Aug 2003 01:20:59 -0400 Received: from mail.jlokier.co.uk ([81.29.64.88]:37253 "EHLO mail.jlokier.co.uk") by vger.kernel.org with ESMTP id S271002AbTHKFU6 (ORCPT ); Mon, 11 Aug 2003 01:20:58 -0400 Date: Mon, 11 Aug 2003 06:20:35 +0100 From: Jamie Lokier To: Matt Mackall Cc: James Morris , linux-kernel , Andrew Morton , davem@redhat.com, tytso@mit.edu Subject: Re: [RFC][PATCH] Make cryptoapi non-optional? Message-ID: <20030811052035.GK10446@mail.jlokier.co.uk> References: <20030809173329.GU31810@waste.org> <20030810174528.GZ31810@waste.org> <20030811020919.GD10446@mail.jlokier.co.uk> <20030811023553.GC31810@waste.org> <20030811045947.GI10446@mail.jlokier.co.uk> <20030811050414.GE31810@waste.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030811050414.GE31810@waste.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 28 Matt Mackall wrote: > On Mon, Aug 11, 2003 at 05:59:47AM +0100, Jamie Lokier wrote: > > Matt Mackall wrote: > > > And we're safe here. The default pool size is 1024 bits, of which we > > > hash 512. I could hash even fewer, say, 480 (and this would deal with the > > > cryptoapi padding stuff nicely). > > > > Where is the pool size set to 1024 bits? I'm reading 2.5.75, and it > > looks to me like the hash is over the whole pool, of 512 bits for the > > primary and 128 bits for the secondary pool: > > > > for (i = 0, x = 0; i < r->poolinfo.poolwords; i += 16, x+=2) { > ^^^^ > > Unfortunately, there's an ugly mix of words, bytes, and bits here (and it > was actually broken for years because of it). The input pool is 4kbits > and the output pools are 1k. You're right about the sizes. But you said it hashes only half of the pool. Where is that? -- Jamie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/