Received: by 10.213.65.68 with SMTP id h4csp575471imn; Sat, 17 Mar 2018 15:28:32 -0700 (PDT) X-Google-Smtp-Source: AG47ELviyDAsyI/Ygz0ewkMqIJIFPI29GyKdt0TWMCfNYtyZHmg1JYR6/TFaCnUIzsovUZQnjRFu X-Received: by 10.99.117.17 with SMTP id q17mr2229892pgc.451.1521325712652; Sat, 17 Mar 2018 15:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521325712; cv=none; d=google.com; s=arc-20160816; b=0tIWeor/AC9cy66abEQPRsX21W54uSflvMJIOQVqt5SxQLL39eWRjuKO93yfuiqvwA GhjlUYs2tjGtZ2KajC2hYpaLeck7PaxkwkXp8sEPuNSZd6OfzlQqdC7LPv8Y4OE2Sz/g gezy96xu882jvM4zLVBP1kHXCGbPGhP9vVNXYL8umiNz8RLvyKhtqCI3ZJUkhDtHqQzO 7Q++qtMwsq3VZEtjAMWPaHlAawflNBYdBu0rS7Nv6KZd7eSpuP5NMXbkBTv3arwt9bae gyZmwHddit4UmL7v64q34ezdCTgWc98iOfQjoBvyVv9lBAn/wqk6zQ9cLzrMhGIym9sh +Smw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dmarc-filter:arc-authentication-results; bh=QydKXPBjbXxbSCkcXAtrHkocvCBr4quvAjUPqF4GieE=; b=AKozmVjYGOFG9Y8KrZu+Vscx72ABA+IKXzrVhZ3N5V7pMnyBdgxl0ZDTBHb/klYSLr BE3abD3btG5zTYBypk7nPvFHndS+v1uTpxTQqCkKqxYNRSpCzMqILn/1NiecbpMtke4K Ltxcr/CVRIQGkV/vWOCmfqbbFn+rPRURdL/y2PTKmUepZF2mSIZiVfsmULIK15fWMzUk 6fF3r6cWJa6JaWE1bLbZ9nGJO/W6Toh6V0kkg/tYgEMfA1oIfR8mo3lJuEFq4qFe8zeP dn+ivzP5r3dcPPXbSEEmQ4a44OdUW43UHEocFl95RhQPkLAdpABkKWOTp5uhxqGLxG9K Ngbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6-v6si8790088pls.583.2018.03.17.15.28.16; Sat, 17 Mar 2018 15:28:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbeCQW1X convert rfc822-to-8bit (ORCPT + 99 others); Sat, 17 Mar 2018 18:27:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:39976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbeCQW1U (ORCPT ); Sat, 17 Mar 2018 18:27:20 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECCC921741; Sat, 17 Mar 2018 22:27:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECCC921741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sat, 17 Mar 2018 22:27:14 +0000 From: Jonathan Cameron To: =?UTF-8?B?SGVybsOhbg==?= Gonzalez Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Daniel Baluta Subject: Re: Plan to move cdc:ad7746 driver out of staging Message-ID: <20180317222714.101ce507@archlinux> In-Reply-To: References: X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Mar 2018 16:25:52 -0300 Hernán Gonzalez wrote: > Hi, > > This is my plan for moving out the ad7746 driver out of staging. I > have some specific questions that would be really helpful if someone > can point me in the right direction to go. > > 1. Pick up on David's clean-up patch. Finish cleaning CHECKs from > checkpatch.pl if possible. > > 2. Reorder includes alphabetically. > > 3. Reorder some variable declarations in an inverse-pyramid scheme. > > 4. Fix sysfs attrs naming to comply with the ABI, e.g.: > in_capacitance0_calibbias_calibration -> in_capacitance0_calibbias Take a careful look at what these are doing before you do that :) Then consider what the usecases are. If we need to, we may need to add new ABI to cover the requirement. > > 5. Add documentation to the {cap,vt}_filter_rate tables and to the > processed info read. There are some magic numbers out there, I will > read the datasheet and explain the math that I consider appropiate. > > 6. There are a few too many defines that are not used at all but they > do follow the datasheet. I don't know if there are plans to keep > adding functionalities to this driver or if I should just remove them. > > 8. EXCLVL is duplicated. There's a simple macro in ad7746.c and some > defines in ad7746.h. The latter are not used anywhere in the code. > Remove them. > > 7. Move the struct ad7746_platform_data to include/linux/iio. > > As mentioned in earlier mails, I will avoid adding new features as I > have no access to the hardware and, therefore, could not test it. Michael has stated he has at least some of the CDCs still so may be able to help with that. > > I guess that'd be all. If I'm missing something I would be really > grateful if you can let me know or give me some pointers where to look > at. It would probably be a good idea to add devicetree bindings if possible. Hardly anything is done with board files these days - though we should maintain the platform data for anyone who is using them (for now). There may well be other things that come out of the woodwork once we do a formal review of the patch that proposes moving it out of staging (there almost always is!) Jonathan > > Cheers, > > Hernán > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html