Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and
 4X
To:     Hal Rosenstock <hal@dev.mellanox.co.il>,
        Honggang LI <honli@redhat.com>, dledford@redhat.com,
        jgg@ziepe.ca, matanb@mellanox.com, leonro@mellanox.com,
        linux-rdma@vger.kernel.org
References: <20180316023713.30323-1-honli@redhat.com>
 <ec18ffec-d7af-9a52-2da3-d4abea23e1a0@dev.mellanox.co.il>
Cc:     linux-kernel@vger.kernel.org
From:   Noa Osherovich <noaos@mellanox.com>
Message-ID: <b8a36b58-8791-97c1-cea6-de36981b83fb@mellanox.com>
Date:   Sun, 18 Mar 2018 09:28:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <ec18ffec-d7af-9a52-2da3-d4abea23e1a0@dev.mellanox.co.il>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2018 07:28:32.3829
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d3ddf837-4cba-4af8-d65e-08d58ca1dad4
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR05MB1060
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/16/2018 4:59 PM, Hal Rosenstock wrote:
> On 3/15/2018 10:37 PM, Honggang LI wrote:
>> From: Honggang Li <honli@redhat.com>
>>
>> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
>> active_speed in RoCE"). Before this patch applied, the mlx5_ib
>> driver set default active_width and active_speed to IB_WIDTH_4X
>> and IB_SPEED_QDR.
>>
>> When the RoCE port is down, the RoCE port did not negotiate the
>> active width with remote side. The active width is zero. If run
>> ibstat to require the port status, ibstat will panic as it read
>> invalid width from sys file.
>>
>> This patch restores the original behavior.
>>
>> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
>> Signed-off-by: Honggang Li <honli@redhat.com>
> Reviewed-by: Hal Rosenstock <hal@mellanox.com>

Reviewed-by: Noa Osherovich <noaos@mellanox.com>

>
>> ---
>>  drivers/infiniband/hw/mlx5/main.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
>> index 033b6af90de9..a48e9730fab8 100644
>> --- a/drivers/infiniband/hw/mlx5/main.c
>> +++ b/drivers/infiniband/hw/mlx5/main.c
>> @@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num,
>>  	if (err)
>>  		goto out;
>>  
>> +	props->active_width     = IB_WIDTH_4X;
>> +	props->active_speed     = IB_SPEED_QDR;
>> +
>>  	translate_eth_proto_oper(eth_prot_oper, &props->active_speed,
>>  				 &props->active_width);
>>  
>>