Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 18 Mar 2018 07:52:45 -0500
From:   Rob Herring <robh@kernel.org>
To:     Archit Taneja <architt@codeaurora.org>
Cc:     Alexandru M Stan <amstan@chromium.org>,
        David Airlie <airlied@linux.ie>,
        Mark Rutland <mark.rutland@arm.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Sean Paul <seanpaul@chromium.org>, devicetree@vger.kernel.org,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Heiko Stuebner <heiko@sntech.de>, briannorris@chromium.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        dianders@chromium.org, linux-rockchip@lists.infradead.org,
        marcheu@chromium.org, hoegsberg@chromium.org,
        Thierry Escande <thierry.escande@collabora.com>,
        Jeffy Chen <jeffy.chen@rock-chips.com>
Subject: Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru
Message-ID: <20180318125245.ndnplplmtsy3hmu7@rob-hp-laptop>
References: <20180316025659.217423-1-amstan@chromium.org>
 <20180316025659.217423-2-amstan@chromium.org>
 <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 16, 2018 at 02:56:09PM +0530, Archit Taneja wrote:
> 
> 
> On Friday 16 March 2018 08:26 AM, Alexandru M Stan wrote:
> > Documentation for the optional backlight-pwm-passthru property.
> > Tells the EDP panel to folow the input pwm frequency instead
> 
> s/folow/follow
> 
> It would be nice if we could add the details you mentioned in
> patch #0 in either this or the next patch.
> 
> > of generating its own.
> 
> This is one of those bindings which is more a knob than a HW property,
> but I can't think of any easy way to figure this out in SW. So, I guess
> it's okay to have.
> 
> One thing I was wondering about was whether this prop should belong to
> the eDP controller or the eDP panel. I don't have any strong opinion
> about it, though.

Seems to me, it should be the panel. It's a setting in the panel, right?

Is this generic to DP panels or something specific to a certain panel? 
The naming (vendor prefix or not) and doc location should match 
whatever the answer to that is.

> 
> Reviewed-by: Archit Taneja <architt@codeaurora.org>
> 
> Thanks,
> Archit
> 
> 
> > 
> > Signed-off-by: Alexandru M Stan <amstan@chromium.org>
> > ---
> > 
> >   Documentation/devicetree/bindings/display/bridge/analogix_dp.txt | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > index 0c7473dd0e51..3c15242f6ce3 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > @@ -23,6 +23,10 @@ Required properties for dp-controller:
> >   		from general PHY binding: Should be "dp".
> >   Optional properties for dp-controller:
> > +	-backlight-pwm-passthru:
> > +		Directly pass the PWM frequency applied to the BL_PWM_DIM
> > +		pin to the backlight current source. Done via
> > +		EDP_BACKLIGHT_MODE_SET_REGISTER on DPCD.
> >   	-force-hpd:
> >   		Indicate driver need force hpd when hpd detect failed, this
> >   		is used for some eDP screen which don't have hpd signal.
> >