Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 18 Mar 2018 16:47:55 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
cc:     kvm@vger.kernel.org, x86@kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
        Mohammed Gamal <mmorsy@redhat.com>,
        Cathy Avery <cavery@redhat.com>, Bandan Das <bsd@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/7] x86/hyper-v: detect nested features
In-Reply-To: <alpine.DEB.2.21.1803181642520.1509@nanos.tec.linutronix.de>
Message-ID: <alpine.DEB.2.21.1803181647420.1509@nanos.tec.linutronix.de>
References: <20180316142220.32506-1-vkuznets@redhat.com> <20180316142220.32506-7-vkuznets@redhat.com> <alpine.DEB.2.21.1803181642520.1509@nanos.tec.linutronix.de>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 18 Mar 2018, Thomas Gleixner wrote:

> On Fri, 16 Mar 2018, Vitaly Kuznetsov wrote:
> >  
> > +	if (ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED)
> > +		ms_hyperv.nested_features =
> > +			cpuid_eax(HYPERV_CPUID_NESTED_FEATURES);
> 
> Please add curly braces. Rationale:
> 
>        https://marc.info/?l=linux-kernel&m=148467980905537
> 
> I know it's a pet pieve, ...

Other than that:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>