Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 18 Mar 2018 21:01:26 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Alexey Roslyakov <alexey.roslyakov@gmail.com>
Cc:     kvalo@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com,
        arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com,
        wright.feng@cypress.com, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com
Subject: Re: [PATCH 1/2] brcmfmac: add new dt entries for SG SDIO settings
Message-ID: <20180318200126.GQ1188@lunn.ch>
References: <20180318184101.26951-1-alexey.roslyakov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180318184101.26951-1-alexey.roslyakov@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> +	if (of_property_read_u16(np, "brcm,sd-head-align", &align) == 0)
> +		sdio->sd_head_align = align;

Hi Alexey

I think you can make this:

	of_property_read_u16(np, "brcm,sd-head-align", &sdio->sd_head_align);

of_property_read_u16() should not touch the destination variable if
the properties does not exist, or if there is an error.

    Andrew