Received: by 10.213.65.68 with SMTP id h4csp1120884imn; Sun, 18 Mar 2018 15:38:17 -0700 (PDT) X-Google-Smtp-Source: AG47ELuEhJN7tYicI0s+G44Swxia7UtpXO4rVByfko7JW1ZSn7sirJGdZdaUQ22cahgf9amlg6hl X-Received: by 2002:a17:902:8206:: with SMTP id x6-v6mr3137540pln.256.1521412697223; Sun, 18 Mar 2018 15:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521412697; cv=none; d=google.com; s=arc-20160816; b=SLuQajS8HTCNtEyCdjcfslRt4UVr3TuYfLbdEIA7Ki3r1PtdTjjJI7y6hmsEC+Houq Qd3lrMCS7wFnOAf5HIR2/7HWc/6hQs5WxLfTTCe8vQ20cge6fIkrAy3yyFxLXp+IkpMj wK9YSK94R2f60gGbcXI7Z0jcbHYsacekEhnBPJi62wtLY4FYgVwVIvhaJ++SMRT+hUH0 wsApqAMUIrcO13w3qpG6I3QeeY8H6GNrw4oJA7asNCkVyJHfRJ1g0NfNck9+gpj+LPaN rLblG8SRelpQf/dIlB8l9qDcdM+u4D6Gvz5d3YaBv/ZKukY005o2vSVBKYfv4KXhGSG8 Q7zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date:from:dkim-signature:arc-authentication-results; bh=kzEodDWNGmT/ngXyo+9yJmG0Y1XDWmE7qKKcKbqFqRc=; b=JMY5YoKF3y2r9rVBOB3eoMDzD1NoSOvOZbUTN44pHjqZgbL8IG4CRveOheoLF6hQ7Z 0mb+aAL3xNnBRQJGEcMDqL0aWzZaTCqnemfOoSmf54K8+WxtpembKrKHmEVf8BW9iwo2 6Z/OgHsFLiGU4tSX1CLtJ91zcaOeQBtVf1stiipSwZ9lKcesy+TzOKyhBAZSpuE9owm8 lLPELXHKbW+hTVjktPgav0bGQhF5wM3Wn4aCfMFJVkOVBqQhN8/71ZWDVBPsRN1fWGL+ /GDGsO4ijPS8lC8kchJwcOws6OdnXWYjftIeaM89Xv4h54IX9njY4gEHSPsWT6tre91L m6yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XqH6eKot; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si9466986pfa.33.2018.03.18.15.38.03; Sun, 18 Mar 2018 15:38:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XqH6eKot; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754693AbeCRWRy (ORCPT + 99 others); Sun, 18 Mar 2018 18:17:54 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35517 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304AbeCRWRw (ORCPT ); Sun, 18 Mar 2018 18:17:52 -0400 Received: by mail-wr0-f194.google.com with SMTP id n12so16744261wra.2; Sun, 18 Mar 2018 15:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kzEodDWNGmT/ngXyo+9yJmG0Y1XDWmE7qKKcKbqFqRc=; b=XqH6eKotyUOhR1nhdK/SiiR341ahtNiQ0jExJKfcPdNlu2FT8Fae530tGjQDCMfEzR AojmRPpp4WH1Mgjfl8NuZAu2ZB9vh8tXvuGzHwdA+ypi4CddCsF7DbR8crR0squSviJi Pzjvga1x/c52BefVcqW4jZmSrvqEzG9qdPAO3N1PiTo3WC2TVcRR6fSj33fjDe87plqt exUT2CowHZwpQdkUF4o1nPJwoQwlF9/TSxqCh6KnI92aPn5kzzBBn3V2MM7/8za83M85 7hQSm2zGTYvn3YW2J92X4J2238M0i0PQvUEVhRAjUZJLDANQ9mmcjhiKaHMVEUpbFhOC Ed3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kzEodDWNGmT/ngXyo+9yJmG0Y1XDWmE7qKKcKbqFqRc=; b=fdI4uyIejTWX+8jyhKigmPZcqYN7tpAe50zwqZDkM3WpQJ7+e2l/74yx1G+QIlGGz2 QzPpiHI8nuUjxCZ8ZyZuz/Tf+ojG1a45OUvJENIzW5OwS0JrJw67ORHGjF0YsvOrvV0A +okipSnRfQSm+jb5apZ1InkOF9qQVQ8W9PVKyrqeM5GmN7pEIFTuOJa25IIgGBE8Ga+7 iTRGWSdpPSDKgHD/XvPQvWtnTuJK9FuOUpkcT63lRC+ENUTMXz7t15ASTCo9MbkMqJLA P386TPaVenepa3/qepEvTTj0IE5vgMJBltThi3gilAoDH/menf9zj2sXs1Ba9aFll9iW 6Xmg== X-Gm-Message-State: AElRT7Fh9xTD0DZ8zAEC8JAQt6HR6UyqQzZMtQuQtNBZvXxJRyyLSt7b vnGxiimUAXJyLUigVU2KUWA= X-Received: by 10.223.142.13 with SMTP id n13mr7013574wrb.133.1521411471352; Sun, 18 Mar 2018 15:17:51 -0700 (PDT) Received: from example.com ([217.112.98.166]) by smtp.gmail.com with ESMTPSA id r6sm13889754wrg.63.2018.03.18.15.17.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 15:17:50 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca Date: Sun, 18 Mar 2018 23:17:37 +0100 To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg , Ulf Magnusson , Eugeniu Rosca , Randy Dunlap , "Luis R . Rodriguez" , Petr Vorel , Eugeniu Rosca , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] kconfig: warn unmet direct dependency of tristate symbols selected by y Message-ID: <20180318221737.GA25547@example.com> References: <1520934968-30406-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520934968-30406-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On Tue, Mar 13, 2018 at 06:56:07PM +0900, Masahiro Yamada wrote: > Commit 246cf9c26bf1 ("kbuild: Warn on selecting symbols with unmet > direct dependencies") forcibly promoted ->dir_dep.tri to yes from mod. > So, the unmet direct dependencies of tristate symbols are not reported. > > [Test Case] > > config MODULES > def_bool y > option modules > > config A > def_bool y > select B > > config B > tristate "B" > depends on m > > This causes unmet dependency because 'B' is forced 'y' ignoring > 'depends on m'. This should be warned. > > On the other hand, the following case ('B' is bool) should not be > warned, so 'depends on m' for bool symbols should be naturally treated > as 'depends on y'. > > [Test Case2 (not unmet dependency)] > > config MODULES > def_bool y > option modules > > config A > def_bool y > select B > > config B > bool "B" > depends on m > > Signed-off-by: Masahiro Yamada > --- > > Changes in v4: > - newly added > > > scripts/kconfig/symbol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c > index 0f7eba7..def860b 100644 > --- a/scripts/kconfig/symbol.c > +++ b/scripts/kconfig/symbol.c > @@ -243,7 +243,7 @@ static void sym_calc_visibility(struct symbol *sym) > tri = yes; > if (sym->dir_dep.expr) > tri = expr_calc_value(sym->dir_dep.expr); > - if (tri == mod) > + if (sym->type == S_BOOLEAN && tri == mod) This seems to be very close to one of the issues fixed in the old v2.6.5 commit 5a87d187fce1 ("[PATCH] config: choice fix") accessible at https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?h=5a87d187fce1 IMHO you could probably use (not tested!): + if (tri == mod && sym_get_type(sym) == S_BOOLEAN) instead of + if (sym->type == S_BOOLEAN && tri == mod) to be consistent with the rest of sym_calc_visibility(). Also, since after this commit there will be a great amount of symmetry between how dirdep/revdep/weak-revdep are calculated inside sym_calc_visibility(), somebody could probably unify the implementations in future (not subject of this patch). > tri = yes; > if (sym->dir_dep.tri != tri) { > sym->dir_dep.tri = tri; > @@ -414,7 +414,7 @@ void sym_calc_value(struct symbol *sym) > } > } > calc_newval: > - if (sym->dir_dep.tri == no && sym->rev_dep.tri != no) { > + if (sym->dir_dep.tri < sym->rev_dep.tri) { Looks good. > struct expr *e; > e = expr_simplify_unmet_dep(sym->rev_dep.expr, > sym->dir_dep.expr); > -- > 2.7.4 > Best regards, Eugeniu.