Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use
 vchan_terminate_vdesc() instead of desc_free
To:     Vinod Koul <vinod.koul@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        Eric Anholt <eric@anholt.net>,
        Sasha Levin <alexander.levin@microsoft.com>
References: <20180316152329.844663293@linuxfoundation.org>
 <20180316152333.462064800@linuxfoundation.org>
 <20180316184640.rxw6kwvqghsmdgcc@xps> <20180317143253.GI15443@localhost>
 <20180318102417.GA30164@kroah.com> <20180318104451.GA19721@kroah.com>
 <20180319030840.GJ15443@localhost>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <e83c7924-7e52-eeab-adf2-ba2af159cfac@ti.com>
Date:   Mon, 19 Mar 2018 09:14:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180319030840.GJ15443@localhost>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2018-03-19 05:08, Vinod Koul wrote:
> On Sun, Mar 18, 2018 at 11:44:51AM +0100, Greg Kroah-Hartman wrote:
>> On Sun, Mar 18, 2018 at 11:24:17AM +0100, Greg Kroah-Hartman wrote:
>>>>> This patch is causing a build error on arm and arm64 per i.e.
>>>>> https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/
>>>>>
>>>>> Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a
>>>>> problem there as well, but I have not verified it yet.
>>>>
>>>> I think we are missing commit 1c7f072d94e8. Pls cherrypick that as well
>>>>
>>>> commit 1c7f072d94e8b697fd9b70cdb268622a18faf522
>>>> Author: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>>> Date:   Tue Nov 14 16:32:04 2017 +0200
>>>>
>>>>     dmaengine: virt-dma: Support for race free transfer termination
>>>>
>>>> This adds vchan_terminate_vdesc API..
>>>
>>> Thanks, that helped.  I've now added this and send out a -rc2 for this
>>> kernel.
>>
>> Oops, no, that broke the build for all arches :(
>>
>> Let me just go drop this patch, and the two dmaengine patches that
>> relied on this one.  If you think these should be applied to the stable
>> trees, can you send me a series of working patches?
> 
> Okay let me grab your tree and cherry-pick all that is required and send
> you. Stay tuned...

I think these are the patches that need to be picked for this to work/compile:

2c6929d2ea70 dmaengine: s3c24xx-dma: Use vchan_terminate_vdesc() instead of desc_free
3ee7e42f3c9b dmaengine: k3dma: Use vchan_terminate_vdesc() instead of desc_free
397c59bce6cb dmaengine: img-mdc-dma: Use vchan_terminate_vdesc() instead of desc_free
47d71bc75d07 dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free
f0dd52c85d61 dmaengine: dma-jz4780: Use vchan_terminate_vdesc() instead of desc_free
de92436ac40f dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
174334bcd9f8 dmaengine: edma: Use vchan_terminate_vdesc() instead of desc_free
b1faf0f564ff dmaengine: omap-dma: Use vchan_terminate_vdesc() instead of desc_free
1c7f072d94e8 dmaengine: virt-dma: Support for race free transfer termination
6af149d2b142 dmaengine: virt-dma: Add helper to free/reuse a descriptor

Most probably we missed the 6af149d2b142 and that caused the build failures.


- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki