Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0973217D6
MIME-Version: 1.0
In-Reply-To: <20180316163107.67gaxcjksn76ztmn@us-sjc-wireless-10-16-34-48.amer.corp.natinst.com>
References: <1521215669-23874-1-git-send-email-p.pisati@gmail.com>
 <1521215669-23874-2-git-send-email-p.pisati@gmail.com> <20180316163107.67gaxcjksn76ztmn@us-sjc-wireless-10-16-34-48.amer.corp.natinst.com>
From:   Alan Tull <atull@kernel.org>
Date:   Mon, 19 Mar 2018 10:42:30 -0500
Message-ID: <CANk1AXQvCVLvSNJJUpazmiqauzHU6bHxn_gayWCFr8aidM=yHw@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi
 binding description
To:     Moritz Fischer <mdf@kernel.org>
Cc:     Paolo Pisati <p.pisati@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-fpga@vger.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 16, 2018 at 11:31 AM, Moritz Fischer <mdf@kernel.org> wrote:
> On Fri, Mar 16, 2018 at 04:54:28PM +0100, Paolo Pisati wrote:
>> Add dt binding documentation details for Lattice MachXO2 FPGA configuration
>> over Slave SPI interface.
>>
>> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
>> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>

Thanks,
Alan

>> ---
>>  .../bindings/fpga/lattice-machxo2-spi.txt          | 29 ++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/fpga/lattice-machxo2-spi.txt
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/lattice-machxo2-spi.txt b/Documentation/devicetree/bindings/fpga/lattice-machxo2-spi.txt
>> new file mode 100644
>> index 0000000..a8c362e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/fpga/lattice-machxo2-spi.txt
>> @@ -0,0 +1,29 @@
>> +Lattice MachXO2 Slave SPI FPGA Manager
>> +
>> +Lattice MachXO2 FPGAs support a method of loading the bitstream over
>> +'slave SPI' interface.
> Nit: a 'slave SPI'
>> +
>> +See 'MachXO2ProgrammingandConfigurationUsageGuide.pdf' on www.latticesemi.com
>> +
>> +Required properties:
>> +- compatible: should contain "lattice,machxo2-slave-spi"
>> +- reg: spi chip select of the FPGA
>> +
>> +Example for full FPGA configuration:
>> +
>> +     fpga-region0 {
>> +             compatible = "fpga-region";
>> +             fpga-mgr = <&fpga_mgr_spi>;
>> +             #address-cells = <0x1>;
>> +             #size-cells = <0x1>;
>> +     };
>> +
>> +     spi1: spi@2000 {
>> +        ...
>> +
>> +             fpga_mgr_spi: fpga-mgr@0 {
>> +                     compatible = "lattice,machxo2-slave-spi";
>> +                     spi-max-frequency = <8000000>;
>> +                     reg = <0>;
>> +             };
>> +     };
>> --
>> 2.7.4
>>
>
> Thanks,
>
> Moritz