Received: by 10.213.65.68 with SMTP id h4csp1690458imn; Mon, 19 Mar 2018 10:39:04 -0700 (PDT) X-Google-Smtp-Source: AG47ELuxZxK+4O8kt5zH1mJLdOik9JJOHgAdtbtAFKN7GH9FpyvS2iwY8MRoRXF8y8SyW/URWZha X-Received: by 2002:a17:902:60cf:: with SMTP id k15-v6mr9262484pln.44.1521481144044; Mon, 19 Mar 2018 10:39:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521481144; cv=none; d=google.com; s=arc-20160816; b=BnrHOJcMDdp7Q2DkjWIQmlNCMGJF0Clkl8btjDmnuUEIJe2ZqSzUxP5BRg6W8AHlIp iIan9MYo/PiFQNfV0a17xEsklIxf4Lhp9tncj64v2u5sbQ94KZyuj5kPo7GX2KWjLBnR SmnY0GgjOA0aAISaEGfv0whWGk6VG961KWYA77JOtKV/LjjjgDqX6MXRk2XlcLXIxIla 1KNaLcXFUHKqdnCLChjeWNBtUUv3cuxSHrTC+fbK+HSiTj7Cqc2k5kqXDdV5uhNJIZON vKArqyEYGj2ZpN8gGKBqtcZbmfbKQD1IS0KMqXS7RfiugBkJ9uMXK3yGwsVzXzfDd2wo rZBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=HOqQMoCDGUkRLGfcZ3TDDT+L1ooU2xe4c74+zNQRG/M=; b=rzksMHvkUODGryHUcJnFIktNGU4U9siPEYEP7zpSSdDqeQIZwOX0EXO3cBpznnQcVc rXA6b/rAxC9CJG3/cDtwDZqoH2I9x8+cUmFEzwrWbk1jCvy5UcOcAh0jQDKHSFPe7JGD RW1gserhZ3IFaVA4tk4gZvsDI3krfgxRiRBJT9lb9Ui5+vpGQjUFTKRxR9C8nixTkm68 Vq7LTLOA60Y1eviFehk4FD5D9UINXhGXjBx+qx2iIUHClhfGRYP8GFyKtvRE9rJ0HDN8 mLGYNoFEz1vwlDEbZYVmpKTuARDFlW0CTltUnOX8GsZ2rLrizr4D+ZRMmo0A32m8igyF dpWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XwqIV0lP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si257660pgv.261.2018.03.19.10.38.49; Mon, 19 Mar 2018 10:39:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XwqIV0lP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967111AbeCSRfy (ORCPT + 99 others); Mon, 19 Mar 2018 13:35:54 -0400 Received: from mail-by2nam03on0122.outbound.protection.outlook.com ([104.47.42.122]:28800 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966026AbeCSQGr (ORCPT ); Mon, 19 Mar 2018 12:06:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HOqQMoCDGUkRLGfcZ3TDDT+L1ooU2xe4c74+zNQRG/M=; b=XwqIV0lPBepCYdq8HZC0zM3ckpNX4k87prt3Sdi8HCej5qT85sP7WruXynr7gjYIJ1TsKYaOlA4geSyNAaTVPt38GSxHouR5cEi7Om64D1GQOEMt8gecpy2oXX3Kv/ob0jP26CeNWzkKx6FAjTpAbH3vcvccEkbOT3p45cXB2LY= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0920.namprd21.prod.outlook.com (52.132.132.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.0; Mon, 19 Mar 2018 16:06:43 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62%5]) with mapi id 15.20.0631.004; Mon, 19 Mar 2018 16:06:43 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Luca Coelho , Johannes Berg , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 008/167] mac80211: bail out from prep_connection() if a reconfig is ongoing Thread-Topic: [PATCH AUTOSEL for 4.4 008/167] mac80211: bail out from prep_connection() if a reconfig is ongoing Thread-Index: AQHTv5wa5e0irY9KvUqzQ0nSdVKJHw== Date: Mon, 19 Mar 2018 16:05:29 +0000 Message-ID: <20180319160513.16384-8-alexander.levin@microsoft.com> References: <20180319160513.16384-1-alexander.levin@microsoft.com> In-Reply-To: <20180319160513.16384-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0920;7:6Wyv5Tqbkhdwn8vRXvjJVpiaYjEcSbMcSoPC7FdmSplrDT5N0Z+9G8eJTvlHIfOb0mlpT4uawMJIqeqXD+x84XTOS5dfGsD1mNNICv/b1hJh2nf9mBX6EAP+N/g0+hptxGSIOJuvjZgN+LS7W/jljsGA61na6hu0ABvP5N0I2wReZU6xsd0GN2Czve7pIzbqBHWXN8UduLJfv5blS+kxvNB7qWWPssXNNV27MOUYHu8vb35mz2fts3bWFYDMZn/F;20:s57YktQ0RB0BQuSkvbGlTcv6ybJwj9BEDjp4eGVf9f/2WUUxCGCYuhdqvDk0P+ZjQVquK992CaZ0WUDm0zayjCH2TYYEGcZE89IdkF19NAyw1xzPl7ZwkJkE3b4awj3p/tbwD4DjR93njdaUG89xM1iP+VSK4m0oEcU7T8DGX4g= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 49352736-b728-4f63-1612-08d58db3684b x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0920; x-ms-traffictypediagnostic: DM5PR2101MB0920: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501300)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:DM5PR2101MB0920;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0920; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(39380400002)(396003)(376002)(39860400002)(366004)(189003)(199004)(6512007)(14454004)(2906002)(2900100001)(8936002)(186003)(86362001)(5250100002)(316002)(966005)(97736004)(2501003)(6116002)(1076002)(3846002)(81166006)(6436002)(6506007)(59450400001)(6486002)(26005)(72206003)(81156014)(53936002)(102836004)(478600001)(10290500003)(6306002)(8676002)(107886003)(6666003)(4326008)(3660700001)(66066001)(25786009)(2950100002)(86612001)(36756003)(54906003)(110136005)(3280700002)(7736002)(305945005)(5660300001)(76176011)(68736007)(22452003)(10090500001)(105586002)(106356001)(99286004)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0920;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /BbVsFyRY7FRnYh9dzYk3pdCU6NSPH501zCxKhVg4o3So/HQNn1EGJEGqBuSwCNLXgDJ5U160mDJqkzZKtdL1e3BqYrulSbNUC6azayIXpgUb3MIG44n/zPbv8p9xD3Q3TMw7NFKUTGMCgZRwcYQirRfi2as5JulEckCY9IcwbH68AmuAiYnODWGJXM6s63uho1kTIX4dASdRwcdccGDWzMzEggzValBEFGeteFMMgqgnZOw4YoeGdomt43RN379U8UqWCMHI4jhD7UDQVeKtFFYZJYBjowiDrCrAnlzKfDbMORanynRuyWsaq9TkEA65S6BvRUxrB482i4YAYu4/w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49352736-b728-4f63-1612-08d58db3684b X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 16:05:29.9628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0920 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luca Coelho [ Upstream commit f8860ce836f2d502b07ef99559707fe55d90f5bc ] If ieee80211_hw_restart() is called during authentication, the authentication process will continue, causing the driver to be called in a wrong state. This ultimately causes an oops in the iwlwifi driver (at least). This fixes bugzilla 195299 partly. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D195299 Signed-off-by: Luca Coelho Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/mlme.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 23095d5e0199..005cd8796505 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -4326,6 +4326,10 @@ static int ieee80211_prep_connection(struct ieee8021= 1_sub_if_data *sdata, if (WARN_ON(!ifmgd->auth_data && !ifmgd->assoc_data)) return -EINVAL; =20 + /* If a reconfig is happening, bail out */ + if (local->in_reconfig) + return -EBUSY; + if (assoc) { rcu_read_lock(); have_sta =3D sta_info_get(sdata, cbss->bssid); --=20 2.14.1