Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272731AbTHKOv6 (ORCPT ); Mon, 11 Aug 2003 10:51:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272708AbTHKOuj (ORCPT ); Mon, 11 Aug 2003 10:50:39 -0400 Received: from host-64-213-145-173.atlantasolutions.com ([64.213.145.173]:18887 "EHLO havoc.gtf.org") by vger.kernel.org with ESMTP id S272680AbTHKOte (ORCPT ); Mon, 11 Aug 2003 10:49:34 -0400 Date: Mon, 11 Aug 2003 10:49:33 -0400 From: Jeff Garzik To: davej@redhat.com Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, jgarzik@redhat.com Subject: Re: [PATCH] misc 3c505 bits Message-ID: <20030811144933.GC32180@gtf.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 31 On Mon, Aug 11, 2003 at 02:40:25PM +0100, davej@redhat.com wrote: > - Remove unneeded breaks > - Fix double spin_unlock_irqrestore problem > > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/3c505.c linux-2.5/drivers/net/3c505.c > --- bk-linus/drivers/net/3c505.c 2003-05-26 12:57:43.000000000 +0100 > +++ linux-2.5/drivers/net/3c505.c 2003-06-04 14:07:40.000000000 +0100 > @@ -449,18 +449,18 @@ static int send_pcb(struct net_device *d > case ASF_PCB_ACK: > adapter->send_pcb_semaphore = 0; > return TRUE; > - break; > + > case ASF_PCB_NAK: > #ifdef ELP_DEBUG > printk(KERN_DEBUG "%s: send_pcb got NAK\n", dev->name); > #endif > goto abort; > - break; Disagree: borks message. You receive an ACK, and print "got NAK". Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/