Received: by 10.213.65.68 with SMTP id h4csp1718408imn; Mon, 19 Mar 2018 11:20:26 -0700 (PDT) X-Google-Smtp-Source: AG47ELv/loS1CiYDwlEg2+aT8YtjcbVZC1AAqw54yFN59W0zI92ET4deNuIsB1xQDk305MV92KwP X-Received: by 2002:a17:902:8c83:: with SMTP id t3-v6mr3646263plo.391.1521483626762; Mon, 19 Mar 2018 11:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521483626; cv=none; d=google.com; s=arc-20160816; b=ZEJazGjzYsZe04UumJCZ0JP4mUCApP0ARgtRlJ44LdTLwjorNhsb8KDgv9d3wydtiw /xjK/0sl81yotBPjkleEQhgWIEikGYsbXp9mk026WE0ZRfRJVrLp8vF40ibo+zyXvAjq pkhchCn99VYA1eXytHPiTxfh3Z/K/QBHEpLtTopM8myolVjn46ztw9f3DV2Bx7C3s2mB 9hH5ljEt9NDSBiErfAj4BQpb2f3z0Qxoab5yq1mE2G77btfN8OFymeOyHkA/CVIfVspw ISa2DU3TWnxBszszb/zmaCKNiJEDTZ5v0e+F3r1lSnppol0Fj0mdFSlqoCN0HuEomtcf K8cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=J20vZTLdvB8c8eLxZ5x/lzcCZtNJv7NIe3bX3+P/yqA=; b=S+4xx9qpTVenGujl0UCfz3lB4t8VW+Fu4KHLConmzpMowuLhS/y8Grax6+W2lJHfil ISFiIecNyhQxL1dHrTzeuyJgcOi9OrQoCiW9yvzDhrUF2Ygm0nY3njr6a30/3js+kl+M XtkZLKXcEbgUybTayEG/aVaBz5dSkM4r+puSojFJJT5A0r54lHgO+AS9AYlUzAffhM4S /ekzPdpKbpxooVWyEwFcd7AwoI0fMHOSwPSsCecQVx+xgTe8Jvm4+dvRqGevoLSXBZuu es1bTdJjNOl3uQYA9pGoTvqL5mdS0MWG+C091dhKQeeheiXARjgHWYtPJLUqWwfUEft/ BUMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si304678pgr.164.2018.03.19.11.20.12; Mon, 19 Mar 2018 11:20:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969333AbeCSSSb (ORCPT + 99 others); Mon, 19 Mar 2018 14:18:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969319AbeCSSS2 (ORCPT ); Mon, 19 Mar 2018 14:18:28 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 74A88E02; Mon, 19 Mar 2018 18:18:27 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mohammed Shafi Shajakhan , Kalle Valo , Sasha Levin Subject: [PATCH 4.9 015/241] ath10k: fix a warning during channel switch with multiple vaps Date: Mon, 19 Mar 2018 19:04:40 +0100 Message-Id: <20180319180751.804953757@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180751.172155436@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mohammed Shafi Shajakhan [ Upstream commit c73f8c00330f59ce9b1ace9ff698aca83390d358 ] Doing a channel switch via hostapd_cli seems to update the new channel context for each VAP's appropriately as below in 'ath10k_mac_update_vif_chan', hence we can safely suppress the warning that shows up during this operation and dump the warning only if no vaps are available for channel switch hostapd_cli -i wlan0 chan_switch 5 5200 OK ath10k_pci : mac chanctx switch n_vifs 3 mode 1 ath10k_pci : mac chanctx switch vdev_id 2 freq 5180->5200 width 0->0 ath10k_pci : mac chanctx switch vdev_id 1 freq 5180->5200 width 0->0 ath10k_pci : mac chanctx switch vdev_id 0 freq 5180->5200 width 0->0 Call Trace: WARNING: backports-20161201-3.14.77-9ab3068/drivers/net/wireless/ath/ath10k/mac.c:7126 [] (warn_slowpath_null) from [] (ath10k_reconfig_complete+0xe4/0x25c [ath10k_core]) [] (ath10k_reconfig_complete [ath10k_core]) [] (ath10k_mac_vif_ap_csa_work+0x214/0x370 [ath10k_core]) [] (ath10k_mac_op_change_chanctx+0x108/0x128 [ath10k_core]) [] (ieee80211_recalc_chanctx_min_def+0x30c/0x430 [mac80211]) [] (ieee80211_recalc_smps_chanctx+0x2ec/0x840 [mac80211]) [] (ieee80211_vif_use_reserved_context+0x7c/0xf8 [mac80211]) [] (ieee80211_vif_use_reserved_context [mac80211]) [] (ieee80211_csa_finalize_work+0x5c/0x88 [mac80211]) Fixes: d7bf4b4aba05 ("ath10k: fix ar->rx_channel updating logic") Signed-off-by: Mohammed Shafi Shajakhan Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -7070,7 +7070,7 @@ ath10k_mac_update_rx_channel(struct ath1 lockdep_assert_held(&ar->data_lock); WARN_ON(ctx && vifs); - WARN_ON(vifs && n_vifs != 1); + WARN_ON(vifs && !n_vifs); /* FIXME: Sort of an optimization and a workaround. Peers and vifs are * on a linked list now. Doing a lookup peer -> vif -> chanctx for each