Received: by 10.213.65.68 with SMTP id h4csp1730889imn; Mon, 19 Mar 2018 11:41:00 -0700 (PDT) X-Google-Smtp-Source: AG47ELuIdF+jCoAWYxMDnA1f2QGL9RWb6fW2wj+gapAhaxfxhMqRKPvaCrSLbmIzFlc60VDPpOh0 X-Received: by 10.98.194.134 with SMTP id w6mr7556602pfk.194.1521484860106; Mon, 19 Mar 2018 11:41:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521484860; cv=none; d=google.com; s=arc-20160816; b=wGdo6a9V6kUhVA9yyyQ45tBm/n3mofTxNiAk2cSLAkzZy3l3YucPVgtgGwRdHGQmdt 6YDVNs2b+SfQugBTgWO1Alp2o0LEK5l6R+l/mzbpe1HPw0N7f+7JLkZIP6doNI3gCNva jhGFXPrqGBHjMfXHyZtWhAitxDZuSh8eAJsGX9IHZv7lppFsDJ7Taf11419I5yoGdJjh OljiPQl5AqtzNIS3gUxGcUsqUxWIiUqZQpWQn1ZyUna/dGVgohnV4D7Ouy9axWnz0Zxk kKj+KlEeVyH2H1DHD6Fe5Sq+x5jVAC+CBSdztAr0E3EOncvi7i70m+MgShOYFnVP++Z7 L+fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=VCtDsT10XlSoI/HNj1UFuPuiEj37GzvVx6s1NSsJWNw=; b=ZL41GjcSd3DrhCW+Iaq00kfY2ZZdWt+zpcFX9WFA2y5xYrfN+l03zRVd/PFDzy9764 dnqn93KDUiFLpBubGRw6DFmeV7VndfsNBfrj9rMCB1QKxgukojZih7G86aZK8yem/Uo2 c/7+h18MFEPUINZlLAHsjfPec77mZuk0ogMzTmDQdXyeFuclJ5kTJcgpBdTJwO1COdOZ 8cbs4Yh+UI5s9ycGfsJWgPSEKso6q8ojw+mh/CUi6veUdMRxRw37MAOTaqTfeXSKoSTd P8vvsg4/mwnyd7wSSQQkr1vP00zapyi0Ncd+HiEo2/O491ugmZwkLQdb69eCLJ8g17/3 /yPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u25si333362pgn.488.2018.03.19.11.40.46; Mon, 19 Mar 2018 11:41:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032165AbeCSSiG (ORCPT + 99 others); Mon, 19 Mar 2018 14:38:06 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de ([131.188.11.21]:40467 "EHLO mx-rz-2.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031928AbeCSSh4 (ORCPT ); Mon, 19 Mar 2018 14:37:56 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de (mx-rz-2.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-2.rrze.uni-erlangen.de (Postfix) with ESMTPS id 404lDg0C3rzPjpJ; Mon, 19 Mar 2018 19:37:55 +0100 (CET) Authentication-Results: mx-rz-2.rrze.uni-erlangen.de; dkim=none reason="no signature"; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Quarantine-ID: <15zTboXudQhW> X-Virus-Scanned: amavisd-new at boeck2.rrze.uni-erlangen.de (RRZE) X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2003:d5:3db:1800:60b5:55d8:d757:229 Received: from fau.de (p200300D503DB180060B555D8D7570229.dip0.t-ipconnect.de [IPv6:2003:d5:3db:1800:60b5:55d8:d757:229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1+ZbBsBHLXQcwGzWSYeIQVbG6U9kJzsh6M=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 404lDb4pnzzPk6B; Mon, 19 Mar 2018 19:37:51 +0100 (CET) From: Jonas Rabenstein To: Jonas Rabenstein , Scott Bauer , Jonathan Derrick , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: [PATCH v2 05/11] block: sed-opal: print failed function address Date: Mon, 19 Mar 2018 19:36:47 +0100 Message-Id: <9c333dc3b35cf9c43061567837de32bf154c2fe4.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> X-Mailer: git-send-email 2.16.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add function address (and if available its symbol) to the message if a step function fails. Signed-off-by: Jonas Rabenstein diff --git a/block/sed-opal.c b/block/sed-opal.c index 30f6e46518a6..9b6f14e7aeb1 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -394,8 +394,8 @@ static int next(struct opal_dev *dev) error = step->fn(dev, step->data); if (error) { - pr_debug("Error on step function: %d with error %d: %s\n", - state, error, + pr_debug("Step %d (%pS) failed wit error %d: %s\n", + state, step->fn, error, opal_error_to_human(error)); /* For each OPAL command we do a discovery0 then we -- 2.16.1