Received: by 10.213.65.68 with SMTP id h4csp1735359imn; Mon, 19 Mar 2018 11:49:59 -0700 (PDT) X-Google-Smtp-Source: AG47ELtCv276E6m1numWN8R0yc9iNZWNbd8tey8jh4MzWXsh/yGEwKU7NgWrLIqYpmjPDpiD5zmL X-Received: by 10.98.194.134 with SMTP id w6mr7574037pfk.194.1521485399501; Mon, 19 Mar 2018 11:49:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521485399; cv=none; d=google.com; s=arc-20160816; b=VvIw5ShQcet7dpCldnVd0BHJg8kwxpi+gkP53ukO4Y1r2Y5+ogy81G7h8dqwvhKXZI /09As2i8rKuLhmG+GA6VzuvPFxAFGv11uuoZ4aTGRN7uVlA8jHlgvNNXTirxp/3PpLGe dSRrSrOQpk4VEC+eQBFgVWiOC0Q61qoEoVyTn/xmtAa18uuPhZsjNuyaR/Aulbzcs4iG 3yvEpZUPsS+Uc1RcuDePWm1gVMFYVtlf6i/Ze9pQjDNjaBN8r8VntJfpJx9mKPRkJJxS K+zGdrxPIShklrL3mW83hVQGFEi7faQQijqUL6DYee5R8ZypnRyvgPgZSSnPXTo+CPIw 7OAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=hx2s4sGnaZK5ycDYhmLeFKqNrS8o1TtFBDG3/x1hjhk=; b=lKqcCmrrJuMAZ5+Zvql+a7Z2HFYmoOp1KT3rHuY9e8rnPfBaxPgP80CkrlydTls804 ySqDJCEyjjk/GDvH9p1n6RJJ1mTYtm10SKP0RedRcTqCYuYqms42QVt26fIkL5kfLYre yEL2TyNAAWoGfWY3cz794XreKEfE7So/um/7DE6fdfB8bzZKekywnruqPWXkzpa5ENLW kGX60bhuzgv5BEkhWj+GJMS0McIol7MjnXugO43cw5SoH04D1gAam52rZYeaBPWgi/yO DOMl4vkrLrNu/Wgzb0sSR27bbGg8E4Wai1chMKzJGlFEtW+x3bHeH4D5SuEHM5ieebIw +Z+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7si302009pgp.212.2018.03.19.11.49.44; Mon, 19 Mar 2018 11:49:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965678AbeCSSrJ (ORCPT + 99 others); Mon, 19 Mar 2018 14:47:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53644 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967385AbeCSSbn (ORCPT ); Mon, 19 Mar 2018 14:31:43 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D669F11B5; Mon, 19 Mar 2018 18:31:42 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Will Deacon , Christoffer Dall , Ard Biesheuvel , Marc Zyngier Subject: [PATCH 4.15 21/52] KVM: arm/arm64: Reduce verbosity of KVM init log Date: Mon, 19 Mar 2018 19:08:19 +0100 Message-Id: <20180319180736.298970050@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180734.976730813@linuxfoundation.org> References: <20180319180734.976730813@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ard Biesheuvel commit 76600428c3677659e3c3633bb4f2ea302220a275 upstream. On my GICv3 system, the following is printed to the kernel log at boot: kvm [1]: 8-bit VMID kvm [1]: IDMAP page: d20e35000 kvm [1]: HYP VA range: 800000000000:ffffffffffff kvm [1]: vgic-v2@2c020000 kvm [1]: GIC system register CPU interface enabled kvm [1]: vgic interrupt IRQ1 kvm [1]: virtual timer IRQ4 kvm [1]: Hyp mode initialized successfully The KVM IDMAP is a mapping of a statically allocated kernel structure, and so printing its physical address leaks the physical placement of the kernel when physical KASLR in effect. So change the kvm_info() to kvm_debug() to remove it from the log output. While at it, trim the output a bit more: IRQ numbers can be found in /proc/interrupts, and the HYP VA and vgic-v2 lines are not highly informational either. Cc: Acked-by: Will Deacon Acked-by: Christoffer Dall Signed-off-by: Ard Biesheuvel Signed-off-by: Marc Zyngier Signed-off-by: Greg Kroah-Hartman --- virt/kvm/arm/arch_timer.c | 2 +- virt/kvm/arm/mmu.c | 6 +++--- virt/kvm/arm/vgic/vgic-v2.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) --- a/virt/kvm/arm/arch_timer.c +++ b/virt/kvm/arm/arch_timer.c @@ -773,7 +773,7 @@ int kvm_timer_hyp_init(bool has_gic) } } - kvm_info("virtual timer IRQ%d\n", host_vtimer_irq); + kvm_debug("virtual timer IRQ%d\n", host_vtimer_irq); cpuhp_setup_state(CPUHP_AP_KVM_ARM_TIMER_STARTING, "kvm/arm/timer:starting", kvm_timer_starting_cpu, --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -1760,9 +1760,9 @@ int kvm_mmu_init(void) */ BUG_ON((hyp_idmap_start ^ (hyp_idmap_end - 1)) & PAGE_MASK); - kvm_info("IDMAP page: %lx\n", hyp_idmap_start); - kvm_info("HYP VA range: %lx:%lx\n", - kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL)); + kvm_debug("IDMAP page: %lx\n", hyp_idmap_start); + kvm_debug("HYP VA range: %lx:%lx\n", + kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL)); if (hyp_idmap_start >= kern_hyp_va(PAGE_OFFSET) && hyp_idmap_start < kern_hyp_va(~0UL) && --- a/virt/kvm/arm/vgic/vgic-v2.c +++ b/virt/kvm/arm/vgic/vgic-v2.c @@ -381,7 +381,7 @@ int vgic_v2_probe(const struct gic_kvm_i kvm_vgic_global_state.type = VGIC_V2; kvm_vgic_global_state.max_gic_vcpus = VGIC_V2_MAX_CPUS; - kvm_info("vgic-v2@%llx\n", info->vctrl.start); + kvm_debug("vgic-v2@%llx\n", info->vctrl.start); return 0; out: