Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266054AbTHKQBh (ORCPT ); Mon, 11 Aug 2003 12:01:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264448AbTHKQBg (ORCPT ); Mon, 11 Aug 2003 12:01:36 -0400 Received: from pix-525-pool.redhat.com ([66.187.233.200]:14118 "EHLO lacrosse.corp.redhat.com") by vger.kernel.org with ESMTP id S272752AbTHKP7l (ORCPT ); Mon, 11 Aug 2003 11:59:41 -0400 To: torvalds@osdl.org From: davej@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] Missing copy_from_user check in comx driver Message-Id: Date: Mon, 11 Aug 2003 16:59:03 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 20 diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/wan/comx-hw-locomx.c linux-2.5/drivers/net/wan/comx-hw-locomx.c --- bk-linus/drivers/net/wan/comx-hw-locomx.c 2003-05-20 18:41:21.000000000 +0100 +++ linux-2.5/drivers/net/wan/comx-hw-locomx.c 2003-07-13 06:04:34.000000000 +0100 @@ -339,7 +339,10 @@ static int locomx_write_proc(struct file return -ENOMEM; } - copy_from_user(page, buffer, count = min_t(unsigned long, count, PAGE_SIZE)); + if (copy_from_user(page, buffer, count = min_t(unsigned long, count, PAGE_SIZE))) { + free_page((unsigned long)page); + return -EBADF; + } if (*(page + count - 1) == '\n') { *(page + count - 1) = 0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/